search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

fixed bug where power curve losses was shifting power curve to the le… #424

Closed grantbuster closed 1 year ago

grantbuster commented 1 year ago

…ft to acheive losses

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 91.42% and project coverage change: +0.04% :tada:

Comparison is base (ddc70df) 86.98% compared to head (3a00de5) 87.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #424 +/- ## ========================================== + Coverage 86.98% 87.03% +0.04% ========================================== Files 122 122 Lines 16950 16990 +40 ========================================== + Hits 14744 14787 +43 + Misses 2206 2203 -3 ``` | [Flag](https://app.codecov.io/gh/NREL/reV/pull/424/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL/reV/pull/424/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | `87.03% <91.42%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/NREL/reV/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/losses/power\_curve.py](https://app.codecov.io/gh/NREL/reV/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2xvc3Nlcy9wb3dlcl9jdXJ2ZS5weQ==) | `93.84% <87.50%> (-0.52%)` | :arrow_down: | | [tests/test\_losses\_power\_curve.py](https://app.codecov.io/gh/NREL/reV/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9sb3NzZXNfcG93ZXJfY3VydmUucHk=) | `98.63% <100.00%> (+0.03%)` | :arrow_up: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/NREL/reV/pull/424/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

grantbuster commented 1 year ago

I tried to poke holes in this but it seems to cover all the cases I could think of so good job! Maybe real data out there will reveal something I overlooked but we can cross that bridge when we get there

Just finished CONUS onshore+offshore runs for both Sup3rCC datasets with 0 errors or warnings, i'm encouraged! going to merge.