search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Degradation #436

Closed WilliamsTravis closed 10 months ago

WilliamsTravis commented 11 months ago

This adds the ability to get lifetime outputs, though with restrictions on which variables may be returned. Definitely open to suggestion about how best to handle the limited available lifetime outputs from SAM.

ppinchuk commented 11 months ago

Gunna have to get those tests fixed before we do much more with this I think

WilliamsTravis commented 11 months ago

Hi, yes definitely, got pulled away by a more pressing issue with the runs i need this for, will fix asap.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0bf8745) 87.02% compared to head (bc23ad1) 87.09%.

Files Patch % Lines
reV/generation/generation.py 92.10% 3 Missing :warning:
tests/test_gen_pv.py 96.15% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #436 +/- ## ========================================== + Coverage 87.02% 87.09% +0.06% ========================================== Files 122 122 Lines 17047 17120 +73 ========================================== + Hits 14836 14911 +75 + Misses 2211 2209 -2 ``` | [Flag](https://app.codecov.io/gh/NREL/reV/pull/436/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL/reV/pull/436/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | `87.09% <94.87%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WilliamsTravis commented 11 months ago

Now it is failing on docstring lines that are over the line length limit, though these were there before and it had passed. Not sure how you'd like to handle this.

ppinchuk commented 11 months ago

Ooops! Those are totally my bad. Not much to do about it though, since we need that length for the link to work (I'm pretty sure?). Anyways, I disabled the check for those docstrings