NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Fix missing techmap bug #437

Closed ppinchuk closed 11 months ago

ppinchuk commented 11 months ago

Techmap now correctly created, even if pre_extract_exclusions is True. Test included. Also bumped GAPs version to include a fix for batch CSV input.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (113ecf8) 87.02% compared to head (f3cd3fd) 87.07%.

Files Patch % Lines
reV/supply_curve/aggregation.py 66.66% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #437 +/- ## ========================================== + Coverage 87.02% 87.07% +0.04% ========================================== Files 122 122 Lines 17044 17060 +16 ========================================== + Hits 14833 14855 +22 + Misses 2211 2205 -6 ``` | [Flag](https://app.codecov.io/gh/NREL/reV/pull/437/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL/reV/pull/437/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | `87.07% <72.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.