codecov-commenter
commented
7 months ago Codecov Report
Attention: Patch coverage is 97.05882% with 4 lines in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
main@9cf454c). Click here to learn what that means. Report is 1 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| reV/supply_curve/exclusions.py | 89.18% | 4 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #449 +/- ## ======================================= Coverage ? 87.32% ======================================= Files ? 122 Lines ? 17439 Branches ? 0 ======================================= Hits ? 15229 Misses ? 2210 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/NREL/reV/pull/449/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL/reV/pull/449/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | `87.32% <97.05%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ppinchuk
Add the ability to specify an extent that a particular exclusion can be applied to.
The extent can be specified in the same way that any other exclusion layer is, but it must come out to be a boolean layer.
Fully recursive excl dict was explored as part of this update, but I could not figure out how to make it work properly without a giant refactor, so am tabling that idea for now. Happy to explore that separately.