NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
107 stars 55 forks source link

Hide output directories #1003

Closed nmerket closed 1 year ago

nmerket commented 2 years ago

Pull Request Description

Hide the output directories for the test projects.

Checklist

Not all may apply:

joseph-robertson commented 1 year ago

Currently,

this fails to download because this fails to upload in an earlier job

@nmerket What is the motivation for making these gitignore changes?

nmerket commented 1 year ago

I did it when I added integration testing to buildstockbatch. It was creating output directories that were showing up as untracked changes. I saw what looked like it should have been those directories in the .gitignore and "fixed" them so they would actually ignore those files.

nmerket commented 1 year ago

@joseph-robertson What made the difference in this working now?

joseph-robertson commented 1 year ago

@joseph-robertson What made the difference in this working now?

Merging in develop. But I don't know why it was failing before. Here is the "Workflow file" when I click on the link for the failed actions. It doesn't even show the job step (i.e., integration-tests: Upload output files) that fails in the run...

nmerket commented 1 year ago

Alright. Well if we're good, we're good. :shipit: