search

NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
105 stars 53 forks source link

rogue `FIXME`s in 'Water Heater Efficiency' options? #1010

Closed spolloni closed 1 year ago

spolloni commented 1 year ago

https://github.com/NREL/resstock/blob/ee49ad68b9bd87fae5045218b3ea0f0d6f7daada/project_testing/housing_characteristics/Solar%20Hot%20Water.tsv#L9

this seems to have propagated into the metadata files of the End Use Savings Shapes

joseph-robertson commented 1 year ago

The "FIXME" string is intentionally inserted into the "Oil Indirect" Water Heater Efficiency option. It is used to denote that we currently model a "storage water heater" instead of a "space-heating boiler with storage tank" (i.e., combi boiler/tank system).

rajeee commented 1 year ago

Related to: https://github.com/NREL/resstock-estimation/issues/61