search

NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
105 stars 53 forks source link

How many decimal places for timeseries output? #1016

Closed joseph-robertson closed 1 year ago

joseph-robertson commented 1 year ago

Currently, it defaults to 3 places. Should it be higher? Should users be able to control this number?

See https://github.com/NREL/OpenStudio-HPXML/pull/1260.

rajeee commented 1 year ago

I recommend 5. https://github.com/NREL/OpenStudio-HPXML/pull/1260#issuecomment-1371543868 But maybe keeping it to 3 by default and recommending people to use msgpack format if they need more than that is also fine. https://github.com/NREL/OpenStudio-HPXML/pull/1260#issuecomment-1372725384

joseph-robertson commented 1 year ago

@nmerket Based on @rajeee's recommendation here, I wonder if we should add 'timeseries_num_decimal_places': 5 into the wfg (and thus break backward compatibility) in https://github.com/NREL/buildstockbatch/pull/337?

nmerket commented 1 year ago

Is there a way we could do it so as to not break backwards compatibility? Like could we have it check to see if the argument exists in the measure, and if it does, then set the default?

joseph-robertson commented 1 year ago

Ah right, we did talk about that. Do we have a precedent (example) for doing that? Perhaps by looking at the measure.xml?

nmerket commented 1 year ago

I don't know if we have a good example of that. I know there's some reading the measure.xml in some of the validators, but that would be a good approach.

Ultimately we should switch to msgpack by default in resstock. Those numbers are being rounded there, so that will need to be addressed first.

rajeee commented 1 year ago

Decided to keep 3 digits.