Bump OS version to 3.5.1 and remove file cleanup workaround

NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.

https://resstock.nrel.gov

Other

104 stars 51 forks source link

Bump OS version to 3.5.1 and remove file cleanup workaround #1036

Closed jaimemarijke closed 1 year ago

jaimemarijke commented 1 year ago

Pull Request Description

Fixes https://github.com/NREL/resstock/issues/1035

Bump OS version to 3.5.1 and remove file cleanup workaround. The original file cleanup issue (https://github.com/NREL/OpenStudio/issues/4761) was fixed in Open Studio by https://github.com/NREL/OpenStudio/pull/4762 and released in OS 3.5.1.

Checklist

Not all may apply:

[ ] Tests (and test files) have been updated
[ ] Documentation has been updated
[ ] Changelog has been updated
[ ] openstudio tasks.rb update_measures has been run
[ ] No unexpected regression test changes on CI (checked comparison artifacts)

shorowit commented 1 year ago

@jaimemarijke Your issue shows that your error occurred on line 76 of xmlvalidator.rb:

:/ruby/2.7.0/fileutils.rb:626:in `rm_r'
/Users/jaime/optionzero/nrgx-energy-modeling/resstock/resources/hpxml-measures/HPXMLtoOpenStudio/resources/xmlvalidator.rb:76:in `cleanup_openstudio_tmp_dir'

This rm_r line now occurs on line 77 because it's been wrapped inside a begin/rescue/end. In other words, I believe this issue has already been addressed.

shorowit commented 1 year ago

Specifically, it was addressed in this commit.

jaimemarijke commented 1 year ago

Specifically, it was addressed in this commit.

Ah, see that now! However, I believe that cleanup code is still unnecessary now right? Isn't the root cause issue fixed in Open Studio 3.5.1?

shorowit commented 1 year ago

The code is still there because ResStock currently allows users to run OS 3.5.0 or 3.5.1. Once ResStock jumps to OS 3.6, we will remove that code.