NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
104 stars 51 forks source link

Support skipping emissions calculations #1041

Closed joseph-robertson closed 1 year ago

joseph-robertson commented 1 year ago

Pull Request Description

[description here]

Checklist

Not all may apply:

rajeee commented 1 year ago

Can we have emissions for other fuels even if electricity emission file is missing?

joseph-robertson commented 1 year ago

@rajeee We cannot. An electricity factor is required. I talked briefly with @shorowit on this one. It's better to not calculate anything than to calculate partial emissions (emissions that only cover a part of the home's energy use), as that could be interpreted incorrectly.

As an alternative to skipping emissions calculations altogether, I suppose we could set an emission factor annual value for electricity (although I don't know what that value should/would be).

shorowit commented 1 year ago

Note that nothing is stopping you from assigning an electricity emissions factor of zero, though I still think it's almost always a bad idea. But perhaps there could be a legitimate use case for it.

rajeee commented 1 year ago

@shorowit The reason we wanted to have this feature is because @afontani is adding Alaska and Hawaii to ResStock and we currently don't have any emissions file for AK and HI. So, although we can't get emissions for electricity in those regions, we could in theory get emissions for other fuels using the default emissions factor. I understand we could force this behavior by setting emissions of zero for electricity. But, yeah, maybe that's a bad approach to take. Any thoughts on that @afontani ?

afontani commented 1 year ago

I like not having values reported if we do not have a full set of inputs. We will need to figure out how to deal with AK and HI as there are no emissions data from Cambium for these states.

@rajeee : We might consider a BuildStock-Batch handling not existing values as NaNs instead of 0 for this field.