NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
104 stars 51 forks source link

Heating system -> heat pump backup #1074

Closed joseph-robertson closed 11 months ago

joseph-robertson commented 1 year ago

Pull Request Description

Closes #942.

Uses ResStockArguments to add a new boolean argument heat_pump_backup_use_existing_system. When set to true in the lookup (i.e., as an upgrade option) the heating system becomes the heat pump backup:

*If existing heating system is an electric furnace, it likely wouldn't be used as integrated backup.

Primary System Backup System Backup Type Example
ducted ducted integrated ASHP w/Furnace (non-electric)
ducted ductless separate ASHP w/Boiler
ductless ducted separate Ductless MSHP w/Furnace
ductless ductless separate Ductless MSHP w/Boiler

Fuel type, efficiency, and capacity are all retained.

If the existing heating system is a heat pump or shared system, it does not get set as the heat pump backup.

This PR also updates national_upgrades.yml and testing_upgrades.yml to demonstrate the new Heat Pump Backup|Use Existing System option for the "ASHP" and "MSHP" upgrades. Also, adds a new "Ductless MSHP" upgrade to these yml files.

image

Checklist

Not all may apply:

joseph-robertson commented 1 year ago

Note that I tested this PR using national_upgrades2.yml.txt:

whiphi92 commented 1 year ago

@joseph-robertson From my testing it looks like baseline homes with backup systems will have their backup systems' sizes retained rather than the primary systems' sizes retained. Is this intended? For example, take a look at building ids 9 + 11 of a run_analysis.rb run using your national_upgrades2.yml file.

joseph-robertson commented 12 months ago

@joseph-robertson From my testing it looks like baseline homes with backup systems will have their backup systems' sizes retained rather than the primary systems' sizes retained. Is this intended? For example, take a look at building ids 9 + 11 of a run_analysis.rb run using your national_upgrades2.yml file.

@whiphi92 You are talking about HP to HP upgrades here?

joseph-robertson commented 12 months ago

@whiphi92 I think this gets complicated when considering upgrades from a primary heating system that serves less than 100% of the heating load (i.e., there is a secondary system in the existing building). This is prompted by the recently merged https://github.com/NREL/resstock/pull/1093. I'm not sure if this is related to the issue you bring up above.

I think the main question is: should the fraction of the heating load served by the upgraded heat pump equal the fraction served by the existing system (i.e., we retain the secondary system), or should it be set to 100% regardless (i.e., we ignore the secondary system)? (Perhaps this only applies when the heat pump backup type is integrated; when separate, the backup system fraction is not allowed, and we're forced to ignore the secondary system.)

whiphi92 commented 11 months ago

@joseph-robertson my intuition is that we would want the heat pump to serve 100% of the load of the dwelling and its backup be the exact size that the original primary system was (even if it only served a fractional percentage of the full load of the dwelling). Does this make sense? Ideally, I suppose, would be that the user can determine whether the heat pump upgrade will serve 100% of the load or just stay the same. We do this with AC via the partial conditioning argument.

joseph-robertson commented 11 months ago

This is the scenario I was trying to convey above:

Existing

Upgraded

Should (A) x=60 and y=40, or (B) x=100 and y=0 (i.e., the Fireplace goes away)?

Sounds like it should be (B). Is that right?

@whiphi92 @shorowit

shorowit commented 11 months ago

There's no single answer, it will depend on the situation. Why not default to A, since the user can choose B if they set secondary heating to None as part of the upgrade (right?).

joseph-robertson commented 11 months ago

There's no single answer, it will depend on the situation. Why not default to A, since the user can choose B if they set secondary heating to None as part of the upgrade (right?).

Good point. I'll try rolling with that.

joseph-robertson commented 11 months ago

@whiphi92 This is ready for another review.

joseph-robertson commented 11 months ago

Plan is to create a new RTD page "Heat Pump Upgrades" (or similar) that addresses the following:

@whiphi92