Closed joseph-robertson closed 11 months ago
Note that I tested this PR using national_upgrades2.yml.txt:
@joseph-robertson From my testing it looks like baseline homes with backup systems will have their backup systems' sizes retained rather than the primary systems' sizes retained. Is this intended? For example, take a look at building ids 9 + 11 of a run_analysis.rb run using your national_upgrades2.yml file.
@joseph-robertson From my testing it looks like baseline homes with backup systems will have their backup systems' sizes retained rather than the primary systems' sizes retained. Is this intended? For example, take a look at building ids 9 + 11 of a run_analysis.rb run using your national_upgrades2.yml file.
@whiphi92 You are talking about HP to HP upgrades here?
@whiphi92 I think this gets complicated when considering upgrades from a primary heating system that serves less than 100% of the heating load (i.e., there is a secondary system in the existing building). This is prompted by the recently merged https://github.com/NREL/resstock/pull/1093. I'm not sure if this is related to the issue you bring up above.
I think the main question is: should the fraction of the heating load served by the upgraded heat pump equal the fraction served by the existing system (i.e., we retain the secondary system), or should it be set to 100% regardless (i.e., we ignore the secondary system)? (Perhaps this only applies when the heat pump backup type is integrated; when separate, the backup system fraction is not allowed, and we're forced to ignore the secondary system.)
@joseph-robertson my intuition is that we would want the heat pump to serve 100% of the load of the dwelling and its backup be the exact size that the original primary system was (even if it only served a fractional percentage of the full load of the dwelling). Does this make sense? Ideally, I suppose, would be that the user can determine whether the heat pump upgrade will serve 100% of the load or just stay the same. We do this with AC via the partial conditioning argument.
This is the scenario I was trying to convey above:
Existing
Upgraded
Should (A) x=60 and y=40, or (B) x=100 and y=0 (i.e., the Fireplace goes away)?
Sounds like it should be (B). Is that right?
@whiphi92 @shorowit
There's no single answer, it will depend on the situation. Why not default to A, since the user can choose B if they set secondary heating to None as part of the upgrade (right?).
There's no single answer, it will depend on the situation. Why not default to A, since the user can choose B if they set secondary heating to None as part of the upgrade (right?).
Good point. I'll try rolling with that.
@whiphi92 This is ready for another review.
Plan is to create a new RTD page "Heat Pump Upgrades" (or similar) that addresses the following:
heat_pump_backup_use_existing_system
operates on all the different types of heating system setups in baseline buildings (PR description above is a good start)heat_pump_backup_heating_lockout_temp
and heat_pump_compressor_lockout_temp
arguments (e.g., 40F and 5F)@whiphi92
Pull Request Description
Closes #942.
Uses ResStockArguments to add a new boolean argument
heat_pump_backup_use_existing_system
. When set totrue
in the lookup (i.e., as an upgrade option) the heating system becomes the heat pump backup:*If existing heating system is an electric furnace, it likely wouldn't be used as integrated backup.
Fuel type, efficiency, and capacity are all retained.
If the existing heating system is a heat pump or shared system, it does not get set as the heat pump backup.
This PR also updates
national_upgrades.yml
andtesting_upgrades.yml
to demonstrate the newHeat Pump Backup|Use Existing System
option for the "ASHP" and "MSHP" upgrades. Also, adds a new "Ductless MSHP" upgrade to these yml files.Checklist
Not all may apply:
openstudio tasks.rb update_measures
has been run