NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
107 stars 54 forks source link

Not all options in options_lookup.tsv are supported in projects_national lookups #1082

Closed jason-curtis closed 1 year ago

jason-curtis commented 1 year ago

I'm seeing a difference between the options in options_lookup.tsv and the dependency values in projects_national/housing_characteristics/*.tsv

Expected:

Actual behavior:

Conditioned Crawlspace does not appear in Ducts.tsv so I can't do that. Only the other choices for Geometry Foundation Type appear to be supported in the probability tables.

Question

Is this intended? I may have misunderstood the purpose of options_lookup.tsv but I expected them all to be supported. I'm not sure if Geometry Foundation Type = Conditioned Crawlspace is the only option like this.

cc @jmarrec

joseph-robertson commented 1 year ago

The options_lookup.tsv is just a map from options to sets of measure argument values. A project is not required to sample all of them. Think of it as the "superset" of all options. Meaning, they are allowed to exist in options_lookup.tsv even if project_national doesn't sample them. The project_testing project, on the other hand, is meant to "test" all options found in the lookup.

It's also possible that options from the lookup are intended to be "upgrade" options - you wouldn't find them in any housing characteristics TSV files (i.e., baseline), but they could be used to define upgrade scenarios in project yml files.

jason-curtis commented 1 year ago

Got it, thank you for the clarification!

On Wed, May 31, 2023 at 3:51 PM Joe Robertson @.***> wrote:

The options_lookup.tsv is just a map from options to sets of measure argument values. A project is not required to sample all of them. Think of it as the "superset" of all options. Meaning, they are allowed to exist in options_lookup.tsv even if project_national doesn't sample them. The project_testing project, on the other hand, is meant to "test" all options found in the lookup.

It's also possible that options from the lookup are intended to be "upgrade" options - you wouldn't find them in any housing characteristics TSV files (i.e., baseline), but they could be used to define upgrade scenarios in project yml files.

— Reply to this email directly, view it on GitHub https://github.com/NREL/resstock/issues/1082#issuecomment-1571066036, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZPVU7XERQF7JL7T7DQTBTXI7DPFANCNFSM6AAAAAAYWCBHDM . You are receiving this because you authored the thread.Message ID: @.***>