search

NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
104 stars 51 forks source link

Other Fuel for Heating leads to no heating system? #1106

Closed mnblonsky closed 1 year ago

mnblonsky commented 1 year ago

I ran a bunch of homes in VT that have Other Fuel as the heating fuel. Other Fuel causes the Heating Efficiency to be "Other", at least most of the time. And that combo leads to "HVAC Heating Type And Fuel" to be None, see: https://github.com/NREL/resstock/blob/30044a09fab85a00082bd5deda8c62ad969d02b6/project_national/housing_characteristics/HVAC%20Heating%20Type%20And%20Fuel.tsv#L105

That causes no heating system to get installed, which seems odd for a significant number of homes in VT. Is this a bug? Happy to share my buildstock.csv file or yaml file if that's helpful.

@lixiliu @jmaguire1

jmaguire1 commented 1 year ago

@mnblonsky: Interesting, but a little out of my depth. Maybe @rajeee would know more about this?

It'd also be helpful if you post your yml here. I think you're downselecting to just homes with electric WH and resampling to get to 2000 samples, which might have something to do with this?

joseph-robertson commented 1 year ago

We actually just recently addressed this in: https://github.com/NREL/resstock/pull/947.

rajeee commented 1 year ago

See related issue here: https://github.com/NREL/resstock/issues/945 @mnblonsky Try with the latest version and let us know if you still have a problem.

mnblonsky commented 1 year ago

Thanks! I'll give it a shot.