Add water heater location

[lixiliu]

Pull Request Description

Addresses Issue: https://github.com/NREL/resstock/issues/1094 ResStock-estimation companion PR: https://github.com/NREL/resstock-estimation/pull/385

• Added Water Heater Location (include fixing other tsvs to remove non-zero Void options)

  • Previously, water heater location is assigned based on OS-HPXML default logics: first available space type:
  • IECC zones 1-3, excluding 3A: “garage”, “living space”
  • IECC zones 3A, 4-8, unknown: “basement - conditioned”, “basement - unconditioned”, “living space”
  • Now, Water Heater Location is informed by RECS 2020 with restrictions on outside and vented space installations for IECC zones 4-8 due to pipe-freezing risk, as advised by @jmaguire1
  • Note: for unknown interaction with Solar Hot Water.tsv (which is being tested in project_testing but not in project_national), Water Heater Location.tsv in project_testing cannot be Outside. Otherwise the combination could cause stochastic failures (in idf) that can be re-simulated successfully without change but would cause CI errors.

• Added Geometry Space Combination, a tsv that combines Geometry Building Type RECS, Geometry Building Level MF, Geometry Foundation Type, Geometry Attic Type, and Geometry Garage. It's used to define which combinations are valid and which are not (~80%) so that downstream tsvs (e.g., Water Heater Location and Duct Location) only use the valid options as a dependency and have smaller file size as a result.

  • Note: The same Geometry Space Combination is used for project_testing as project_national. As a result, Geometry Attic Type and Geometry Foundation Type for project_testing are modified to be consistent with the new tsv. The modification affected Mobile Home, which previously can have all attic and foundation types for testing, but is now only assigned Flat Roof (Attic Type=None) and Ambient Foundation Type per project_national. However, the full combinations of attic and foundation types are still being tested by Single-Family Detached.

• Updated Geometry Garage and Geometry Floor Area Bin (no change as it is a lookup map) to RECS2020

• Tsvs may have changed due to updating RECS2020 data from v2 to v4 (which contains floor area to enable the update of Geometry Floor Area Bin and Geometry Garage)

• Added script to automate precomputed buildstocks generation.

Comparison of CI artifact project_national results to Develop (i.e., ./test/base_results/baseline/annual/results* - project_national rows): water_heater_location_artifact_compare.xlsx

Checklist

Not all may apply:

• [x] Tests (and test files) have been updated
• [x] Documentation has been updated
  • [x] If related to resstock-estimation, checklist includes data dictionary, source report, options_lookup.
  • [x] If changes to project_testing tsvs, checklist includes yml_precomputed, yml_precomputed_outdated, yml_precomputed_weight
• [x] Changelog has been updated
• [x] openstudio tasks.rb update_measures has been run
• [x] No unexpected regression test changes on CI (checked comparison artifacts)

[joseph-robertson]

So unit-tests must complete before analysis-tests, which is going to add ~20-30 min to our ci tests. I suppose this is OK, if there's no other way to support the precomputed test file updates.

[lixiliu]

So unit-tests must complete before analysis-tests, which is going to add ~20-30 min to our ci tests. I suppose this is OK, if there's no other way to support the precomputed test file updates.

@joseph-robertson It's not a hard requirement for pre-computed test file update. It's just that the unit tests would be able to check for structural errors that would cause sampling to hang, so it would be nice to run that before both analysis and integration tests which involve running yamls. It's fine to roll back if that's preferred.