NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
103 stars 51 forks source link

BuildStockBatch version check doesn't work #1155

Closed rajeee closed 8 months ago

rajeee commented 8 months ago

In my recent run attempt, I encountered this error: failed with BuildStockBatch version 2023.5.0 or above is required. Found version: 2023.10.0 Version checking is currently using Lexicographic comparison but this doesn't work with calendar version we are using. We need to break the string by "." and compare each part separately.

joseph-robertson commented 8 months ago
irb(main):002:0> '2023.10.0' < '2023.5.0'
=> true
irb(main):003:0> Gem::Version.new('2023.10.0') < Gem::Version.new('2023.5.0')
=> false

We anticipated that older versions of ResStock would hit this error when trying to use BuildStockBatch v2023.10.0. I think the guidance is to either (A) update to the develop branch of ResStock, or (B) comment out the version check.

rajeee commented 8 months ago

Ahh, this is already fixed. Got it.