Closed afontani closed 7 months ago
@afontani I suppose the addition of "Ground Thermal Conductivity.tsv" reshuffles samples? So, using comparisons of results from CI, it's hard to get an idea of impact here? I wonder if it makes sense to do a base/feature comparison where a fixed buildstock.csv is used (i.e., introduce the new tsv to the base branch, but the lookup assigns the original defaulted value of 1.0)?
@afontani I suppose the addition of "Ground Thermal Conductivity.tsv" reshuffles samples? So, using comparisons of results from CI, it's hard to get an idea of impact here? I wonder if it makes sense to do a base/feature comparison where a fixed buildstock.csv is used (i.e., introduce the new tsv to the base branch, but the lookup assigns the original defaulted value of 1.0)?
@joseph-robertson : Yeah, any characteristic changes shuffle samples and the artifact comparisons are less useful. Their aggregate impact should give a sense of what the changes are. Let me create a couple plots.
@joseph-robertson : I took a look at bar charts using the datapoint base and feature results. I did not see significant changes outside the uncertainty expected with this sample size. Small increases in delivered heating and a small reduction in delivered cooling. This is expected as the ground conductivity is increasing.
Examples:
Pull Request Description
Companion PR: resstock-estimation PR #393
Allow ground conductivity to vary by climate zone. The GeoVision task force report provided data by climate zone. The same data is used to fill out distributions by climate zone.
Data source
Assumptions:
Raw Data Distributions by IECC Climate and Moisture Zone
Checklist
Not all may apply:
openstudio tasks.rb update_measures
has been run