NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
103 stars 51 forks source link

Add variability in ground thermal conductivity #1165

Closed afontani closed 7 months ago

afontani commented 7 months ago

Pull Request Description

Companion PR: resstock-estimation PR #393

Allow ground conductivity to vary by climate zone. The GeoVision task force report provided data by climate zone. The same data is used to fill out distributions by climate zone.

Data source

Assumptions:

Raw Data Distributions by IECC Climate and Moisture Zone

Ground-Conductivity-Histograms

Checklist

Not all may apply:

joseph-robertson commented 7 months ago

@afontani I suppose the addition of "Ground Thermal Conductivity.tsv" reshuffles samples? So, using comparisons of results from CI, it's hard to get an idea of impact here? I wonder if it makes sense to do a base/feature comparison where a fixed buildstock.csv is used (i.e., introduce the new tsv to the base branch, but the lookup assigns the original defaulted value of 1.0)?

afontani commented 7 months ago

@afontani I suppose the addition of "Ground Thermal Conductivity.tsv" reshuffles samples? So, using comparisons of results from CI, it's hard to get an idea of impact here? I wonder if it makes sense to do a base/feature comparison where a fixed buildstock.csv is used (i.e., introduce the new tsv to the base branch, but the lookup assigns the original defaulted value of 1.0)?

@joseph-robertson : Yeah, any characteristic changes shuffle samples and the artifact comparisons are less useful. Their aggregate impact should give a sense of what the changes are. Let me create a couple plots.

afontani commented 7 months ago

@joseph-robertson : I took a look at bar charts using the datapoint base and feature results. I did not see significant changes outside the uncertainty expected with this sample size. Small increases in delivered heating and a small reduction in delivered cooling. This is expected as the ground conductivity is increasing.

Examples: Screen Shot 2023-12-01 at 2 33 11 PM Screen Shot 2023-12-01 at 2 34 21 PM