search

NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
103 stars 51 forks source link

Generate detailed setpoints #1239

Closed rajeee closed 1 month ago

rajeee commented 2 months ago

Pull Request Description

Generate detailed setpoints from the schedule generator. Ensure that the setpoint follows the exact same values as the existing weekday/weekend setpoint schedule. This is in preparation of load flexibility analysis that will need to modify the setpoints. This PR also simplifies the handling of the offset period. Instead of providing offset schedule for each shifting (+5 hour to -5 hour), ResStock only needs to pass the shift hours. Shifting can also be set to "auto" which will result in random shifting of +-5 hours, further simplifying the workflow.

Checklist

Not all may apply:

shorowit commented 1 month ago

I was reminded of @joseph-robertson's similar PR here. How is this different?

rajeee commented 1 month ago

I was reminded of @joseph-robertson's similar PR here. How is this different?

I think it's similar goal. That PR is quite old now though and possibly cannot be merged. I am going to close this PR too - have opened one in OS-HPXML instead: https://github.com/NREL/OpenStudio-HPXML/pull/1726/ and will later have the supporting PR in ResStock.