Use project workflows "Auto-add to project"

NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.

https://resstock.nrel.gov

Other

103 stars 51 forks source link

Use project workflows "Auto-add to project" #1248

Closed joseph-robertson closed 4 weeks ago

joseph-robertson commented 1 month ago

Pull Request Description

Boom. Works:

Thanks @shorowit for pointing this out!

Checklist

Not all may apply:

[ ] ~Tests (and test files) have been updated~
[ ] ~Documentation has been updated~
- [ ] ~If related to resstock-estimation, checklist includes data dictionary, source report, options saturation, options_lookup.~
[ ] ~Changelog has been updated~
[ ] ~openstudio tasks.rb update_measures has been run~
[x] No unexpected regression test changes on CI (checked comparison artifacts)

joseph-robertson commented 1 month ago

Turns out we may be limited to only 1 repository per project workflow. That means, using this approach, we wouldn't be able to automate resstock-estimation or buildstockbatch in addition to resstock...

joseph-robertson commented 1 month ago

@afontani Leaving it up to you whether we want to merge this. The only downside to merging it in, as I see it, is that we are no longer consistent with resstock-estimation/buildstockbatch/etc in terms of an add_to_project.yml workflow file.

afontani commented 4 weeks ago

Unfortunately, I think we should close this PR. It would have been nice to reduce the amount of code, but the 1 project limit I think is a deal breaker for me.