NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.
https://resstock.nrel.gov
Other
103 stars 51 forks source link

Reduce garage protrusion slightly for 0-499 Geometry Floor Area #1258

Closed joseph-robertson closed 1 week ago

joseph-robertson commented 2 weeks ago

Pull Request Description

Closes #1255.

With geometry_garage_protrusion=0.75 => "Garage is as wide as the single-family detached unit." With geometry_garage_protrusion=0.7 => "Garage is as deep as the single-family detached unit." With geometry_garage_protrusion=0.72 => No error.

Add a new test_create_geometry_envelope test to the ResStockArguments test file for running OS-HPXML's create_geometry_envelope on the 10K datapoints from the national project. This test will catch any future issues like the one this PR fixes. 10K datapoints adds about 30 minutes to the overall CI runtime, but a random 80% from that same 10K is pretty even.

Checklist

Not all may apply: