Fix pool pump probabilities

NREL / resstock

Highly granular modeling of residential building stocks at national, regional, and local scales using OpenStudio/EnergyPlus.

https://resstock.nrel.gov

Other

104 stars 51 forks source link

Fix pool pump probabilities #386

Closed ejhw closed 4 years ago

ejhw commented 4 years ago

In this commit, we accidentally changed pool pump probability to 100%. It should instead be whatever fraction/multiplier was previously being used for the National Average pool pump option. https://github.com/NREL/OpenStudio-BuildStock/commit/69a35b988fe6d7200c5b0fa0b76d8980a894805c#commitcomment-37116887

Pool heater probabilities look to be correct, though there may be opportunities for improvement:

Consider making gas pool heating dependent on Heating Fuel
Consider making pool pumps and pool heaters depend on region/climate zone based on RECS data

cc @afontani @ekpresent

joseph-robertson commented 4 years ago

Should SFA or MF buildings ever have pools?

afontani commented 4 years ago

@joseph-robertson: For Los Angeles, we did not model multifamily/SFA pools. Since we are going toward a single unit representation, I would say no we should not model MF and SFA units with pools. As we get better with common spaces, I would include them there.

ejhw commented 4 years ago

In RECS, SFA homes can have pools.

JLReyna commented 4 years ago

In reality, SFA can have either shared pools (in common areas) or individual pools. @ejhw do you know if RECS reports common area pools or just individual pools? It's not obvious from the codebook. If available, I would vote we add in SFA individual pools, but not common area pools

ejhw commented 4 years ago

@JLReyna Looks like individual pools only: