NREL / rex

REsource eXtraction Tool (rex)
https://nrel.github.io/rex
BSD 3-Clause "New" or "Revised" License
19 stars 10 forks source link

NSRDB resource is called with `mode` in some nsrdb tests. Adding this… #146

Closed bnb32 closed 1 year ago

bnb32 commented 1 year ago

… to AbstractInterpolatedResource.init

bnb32 commented 1 year ago

Can you make mode the second kw argument? To match h5py.File(fp, 'r')

Sure. Is that preferred to matching the BaseResource signature?

grantbuster commented 1 year ago

Yes, please update the base resource signature too.