search

NREL / rex

REsource eXtraction Tool (rex)
https://nrel.github.io/rex
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

Gb/bc #170

Closed grantbuster closed 10 months ago

grantbuster commented 10 months ago

Implemented more bias correction methods motivated by Sup3rCC.

Example: map_bespoke_bc

grantbuster commented 10 months ago

Man, that Quantile Delta Mapping bias correction looks SO GOOD!

Excellent job with the code and especially with the docstrings!! I have added a few suggestions below, all of which can be ignored.

I didn't check any of the actual algorithm logic, since I'm not familiar with it. Maybe good to have Brandon take a look too if he know more about it?

Thanks Paul! Generally i think this could be really useful for us in using ERA or HRRR as resource inputs for 2015-present.

I shuffled some things around a little bit in response to your comments. The table parsing function is awkward because it creates a circular import so i moved it to its own file and created a real bc utils file. Added @bnb32 as he said he wants to take a look at the QDM method.