search

NREL / rex

REsource eXtraction Tool (rex)
https://nrel.github.io/rex
BSD 3-Clause "New" or "Revised" License
19 stars 10 forks source link

Gb/hsds #173

Closed grantbuster closed 6 months ago

grantbuster commented 6 months ago

@ppinchuk do you want to review?

Main changes:

Updated HSDS example: https://github.com/NREL/rex/pull/173/files#diff-8e3dc1cf4937eb48f1e5e34cf551cb459fd8ff51eac95654e9dbc984cd5270bcR67

Added tests accessing the NREL hsds files: https://github.com/NREL/rex/pull/173/files#diff-ca58d3473ecb7bec61e877db4c21fab8c877dee489bcb38f1663abcb4569cb31R3

Added a centralized NREL data access example: https://github.com/NREL/rex/pull/173/files#diff-2a920f719a2912083603f8b2c12d4561e98bb950716eb0c40ace87474ba975e8

Pointed resource specific examples to the central NREL data access page: https://github.com/NREL/rex/pull/173/files#diff-a686d114d96c8123b2b37521f58a58e88d32c20d5b831707a42a04876fff1fb9R4

ppinchuk commented 6 months ago

Yes, I skimmed it right now and it generally looks good, but I will also take a deeper look this evening. Don't let me hold you up if you need to get this merged fast though

grantbuster commented 6 months ago

Yes, I skimmed it right now and it generally looks good, but I will also take a deeper look this evening. Don't let me hold you up if you need to get this merged fast though

Yeah I would prefer to merge now and we can edit the example.rst files in place later if that's okay with you! All the current stuff is broke a.f. so would like to get it replaced lol.

ppinchuk commented 6 months ago

Yup, go for it!