search

NREL / rlmolecule

A reinforcement learning library for material and molecule optimization
BSD 3-Clause "New" or "Revised" License
30 stars 9 forks source link

Shree changes to incorporate Redox #110

Closed shreesowndarya closed 2 years ago

shreesowndarya commented 2 years ago

Added in the Redox

lgtm-com[bot] commented 2 years ago

This pull request fixes 4 alerts when merging e700859ce44083a8d425eb19aaab110edd0bd616 into 06f72322df76274a8a094b975d155dd0e1368fd2 - view on LGTM.com

fixed alerts:

pstjohn commented 2 years ago

Hey Shree,

Looks like we worked on some of the same things between here and #109? Or did you copy some of edits over to a different PR?

looks like we're working in different folders though. I was thinking most of this code would live in examples/redox, since including it as part of the main package might add additional dependencies

Could we rebase this on main and clean up some of the duplicated code?

shreesowndarya commented 2 years ago

Yes I can do that!

Thanks, Shree

On Wed, 27 Jul 2022 at 7:24 AM, Peter St. John @.***> wrote:

Hey Shree,

Looks like we worked on some of the same things between here and #109 https://github.com/NREL/rlmolecule/pull/109? Or did you copy some of edits over to a different PR?

looks like we're working in different folders though. I was thinking most of this code would live in examples/redox, since including it as part of the main package might add additional dependencies

Could we rebase this on main and clean up some of the duplicated code?

— Reply to this email directly, view it on GitHub https://github.com/NREL/rlmolecule/pull/110#issuecomment-1196758849, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG2A6ZMA4JQVUBVOUYUA2HLVWEZ7NANCNFSM54TV27PQ . You are receiving this because you authored the thread.Message ID: @.***>

shreesowndarya commented 2 years ago

I have added in additional rewards as reward2 and reward3. Is this structure of folders ok?