NREL / rlmolecule

A reinforcement learning library for material and molecule optimization
BSD 3-Clause "New" or "Revised" License
30 stars 9 forks source link

2021 06 22 parametric molecule builder #95

Closed pstjohn closed 3 years ago

pstjohn commented 3 years ago

Charles' changes

codecov-commenter commented 3 years ago

Codecov Report

Merging #95 (71f9c8f) into devel (9e98ee9) will decrease coverage by 7.67%. The diff coverage is 10.21%.

lgtm-com[bot] commented 3 years ago

This pull request introduces 16 alerts when merging 8aad655190aa56bfc2eb3b00f0aca023f49a3942 into fe63d814b0d8ed1549da925369f24ad8fb4ce692 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 16 alerts when merging 8138b6abb2083b629a14a1726aad81de2f099ff6 into 35320806feda1f070ca5108a7b954e35edfc3dff - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 22 alerts when merging 26596ba3666c6574ef2aeebec768c75320f01872 into 9e98ee9136221a1fdf6aa29f8641d7db0bc3ac44 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 2 when merging cba1ec30e6c73953264979ce9de7543a5067b622 into 9e98ee9136221a1fdf6aa29f8641d7db0bc3ac44 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 48 when merging 27e428b8ca24ca51b2bb60491b69059c8239df88 into 20168456ba651a35f95abceb6ea618c32cfa83d7 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 48 when merging 1544d196b6316f092e8b7c462e389c4526009618 into 20168456ba651a35f95abceb6ea618c32cfa83d7 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 48 when merging 106a0ea55bead73505a5a326add5fcea0cec11e2 into 20168456ba651a35f95abceb6ea618c32cfa83d7 - view on LGTM.com

new alerts:

fixed alerts:

CharlesEdisonTripp commented 3 years ago

I've completed my cleanup. We should discuss how to best run rllib tests on the parametric molecule builder environment and see if any additional changes in this branch are warranted before merging.

lgtm-com[bot] commented 3 years ago

This pull request fixes 48 alerts when merging 45d761ca4f32ee73a1a8fa0ea4b0cd2017d50b78 into 20168456ba651a35f95abceb6ea618c32cfa83d7 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 48 alerts when merging 75810370ee806832be1611903a028ae399965d9b into 20168456ba651a35f95abceb6ea618c32cfa83d7 - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 4 alerts and fixes 48 when merging d073f3ccc2fb5cb07aca18a4126c39788b814a12 into 20168456ba651a35f95abceb6ea618c32cfa83d7 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 4 alerts and fixes 48 when merging 289d0f6d6c834ff5aefe3adbfce005cc3c4a4f3c into 20168456ba651a35f95abceb6ea618c32cfa83d7 - view on LGTM.com

new alerts:

fixed alerts:

CharlesEdisonTripp commented 3 years ago

Ok. I think this is ready to merge. Please do a final check.

lgtm-com[bot] commented 3 years ago

This pull request introduces 4 alerts and fixes 48 when merging 71f9c8f4f7c8d5815f7d738b84ab9797efa1045f into 1fba4f9cdd633bbf77acff9ab20f6a8c0c77a2c6 - view on LGTM.com

new alerts:

fixed alerts: