search

NREL / rplexos

Other
18 stars 13 forks source link

Issue with dev version of dplyr #37

Closed hadley closed 9 years ago

hadley commented 9 years ago

The unit tests fail with the development version of dplyr. Could you please take a look?

hadley commented 9 years ago

The most likely cause is that dplyr 0.4.2 now doesn't object when you give it columns with attributes, instead doing it's best to preserve them

eibanez commented 9 years ago

I will take a look. Thanks for the heads up, Hadley.

On Thursday, June 4, 2015, Hadley Wickham notifications@github.com wrote:

The most likely cause is that dplyr 0.4.2 now doesn't object when you give it columns with attributes, instead doing it's best to preserve them

— Reply to this email directly or view it on GitHub https://github.com/NREL/rplexos/issues/37#issuecomment-109018677.

eibanez commented 9 years ago

Fixed! I will include this in a future submission

hadley commented 9 years ago

Thanks! Do you think you could submit this week? I'd like to get this version of dplyr to CRAN

eibanez commented 9 years ago

I can do that. I'll submit by Friday at the latest.

eibanez commented 9 years ago

@hadley, the revised version has been accepted to CRAN.