New dplyr version changes

danielsjf commented 8 years ago

The new dplyr version changes some default behavior that breaks the rplexos code.

rbind still works but will be depreciated in a future dplyr release. Therefore, as of version 0.5.0, this function will throw warnings.
collect now only reads the first 100 000 lines by default. It is possible to change this by using the argument n=Inf. However, for now this will break some code.

danielsjf commented 8 years ago

I committed some changes to my own fork of the package that should solve these issues.

danielsjf commented 8 years ago

@claytonpbarrows is it the goal to continue the package as a CRAN package? I saw that it was removed from CRAN recently.

claytonpbarrows commented 8 years ago

That was the goal of some of the recent activity. However, I do not have the bandwidth to conform to the CRAN requirements. Therefore, I am inclined to commit the built package to this repository and forget about posting to CRAN.

danielsjf commented 8 years ago

Could you send me the feedback? I will see if I have time to make potential small edits. Never uploaded anything to CRAN though so no idea if it would be a lot of work. But it would be a pity to not have it on CRAN.

claytonpbarrows commented 8 years ago

I created new issues #49 and #50 that should cover all of the feedback that is pasted below:

Found the following (possibly) invalid URLs:
  URL: http://cran.r-project.org/web/packages/rplexos/index.html
    From: README.md
    Status: 200
    Message: OK
    CRAN URL not in canonical form
  The canonical URL of the CRAN page for a package is
  https://cran.r-project.org/package=pkgname

* checking examples ... ERROR
Running examples in ‘rplexos-Ex.R’ failed
The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")
### Name: process_folder
### Title: Convert PLEXOS files to SQLite databases
### Aliases: process_folder process_input process_solution
### ** Examples
# Process the folder with the solution file provided by rplexos
location <- location_solution_rplexos()
process_folder(location)
Warning: Log in solution '/home/hornik/tmp/CRAN/rplexos.Rcheck/rplexos/extdata/solution/Model_Base_Solution.zip' did not parse correctly.
    Data parsed correctly if no other errors were found.
# Process the folder with the input file provided by rplexos
location2 <- location_input_rplexos()
process_folder(location2)
Error in sqliteSendQuery(con, statement, bind.data) :
  error in statement: no such column: comp_collection
Calls: process_folder ... .local -> sqliteGetQuery -> sqliteSendQuery -> .Call
Execution halted
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ... [12s/12s] OK
  Running ‘testthat.R’ [11s/11s]
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking re-building of vignette outputs ... WARNING
Error in re-building vignettes:
  ...
Quitting from lines 186-187 (rplexos.Rmd)
Error: processing vignette ‘rplexos.Rmd’ failed with diagnostics:
error in statement: no such column: comp_collection
Execution halted

Pls fix

-k

[This was generated from CRAN.R-project.org/submit.html]
The following package was uploaded to CRAN:
===========================================

Package Information:
Package: rplexos
Version: 1.1.7
Title: Read and Analyze 'PLEXOS' Solutions
Author(s): Clayton Barrows [cre, ctb], Eduardo Ibanez [aut], Jef Daniels
   [aut], Marcin Kalicinski [ctb] (for the included RapidXml
   source), National Renewable Energy Laboratory [cph]
Maintainer: Clayton Barrows <clayton.barrows@nrel.gov>
Depends: R (>= 3.1.0)
Suggests: knitr, testthat, ggplot2
Description: Efficiently read and analyze 'PLEXOS' solutions by converting
   them into 'SQLite' databases that can be easily queried. It
   supports collation of solutions that may have been divided
   into different time partitions, as well as the comparison
   across different scenarios. 'PLEXOS' is a power systems
   production cost model, created and distributed by Energy
   Exemplar (see URL below for more information).
License: MIT + file LICENSE
Imports: Rcpp (>= 0.11.5), dplyr (>= 0.3), RSQLite (>= 1.0), DBI,
   data.table, tidyr, lubridate, stringi, parallel, doParallel,
   foreach
LinkingTo: Rcpp (>= 0.11.5)

The maintainer confirms that he or she
has read and agrees to the CRAN policies.

=================================================

Original content of DESCRIPTION file:

Package: rplexos
Type: Package
Title: Read and Analyze 'PLEXOS' Solutions
Version: 1.1.7
Date: 2016-08-17
Authors@R: c(
     person("Clayton","Barrows", , "clayton.barrows@nrel.gov", c("cre","ctb")),
     person("Eduardo", "Ibanez", , "edu.ibanez@gmail.com", c("aut")),
     person("Jef", "Daniels", , " ", role=c("aut")),
     person("Marcin", "Kalicinski", , "kalita@poczta.onet.pl", "ctb", "for the included RapidXml source"),
     person("National Renewable Energy Laboratory", role = "cph")
     )
Description: Efficiently read and analyze 'PLEXOS' solutions by converting
     them into 'SQLite' databases that can be easily queried. It supports collation
     of solutions that may have been divided into different time partitions, as
     well as the comparison across different scenarios. 'PLEXOS' is a power systems
     production cost model, created and distributed by Energy Exemplar (see URL below
     for more information).
License: MIT + file LICENSE
URL: https://github.com/NREL/rplexos,
         http://energyexemplar.com/software/plexos-desktop-edition/
BugReports: https://github.com/NREL/rplexos/issues
Depends: R (>= 3.1.0)
Imports: Rcpp (>= 0.11.5), dplyr (>= 0.3), RSQLite (>= 1.0), DBI,
         data.table, tidyr, lubridate, stringi, parallel, doParallel,
         foreach
Suggests: knitr, testthat, ggplot2
LinkingTo: Rcpp (>= 0.11.5)
VignetteBuilder: knitr
RoxygenNote: 5.0.1
NeedsCompilation: yes
Packaged: 2016-08-17 14:22:15 UTC; cbarrows
Author: Clayton Barrows [cre, ctb],
   Eduardo Ibanez [aut],
   Jef Daniels [aut],
   Marcin Kalicinski [ctb] (for the included RapidXml source),
   National Renewable Energy Laboratory [cph]
Maintainer: Clayton Barrows <clayton.barrows@nrel.gov>

danielsjf commented 8 years ago

Could you add me as a collaborator to this repository or do you rather have that I keep submitting them to my own clone?

claytonpbarrows commented 8 years ago

I have requested our IT department to add you. We don't typically get admin to our repos here...

danielsjf commented 8 years ago

Ok, I just pushed all the changes to my repo. This should normally fix the issues related to the CRAN submission.

NREL / rplexos

New dplyr version changes #46