Update to address SAM issue 1477 for host developer only

NREL / ssc

SAM Simulation Core (SSC) contains the underlying performance and financial models for SAM

BSD 3-Clause "New" or "Revised" License

78 stars 83 forks source link

Update to address SAM issue 1477 for host developer only #1141

Closed sjanzou closed 1 week ago

sjanzou commented 4 months ago

I think we should review in detail before proceeding with host developer and other markets.

See https://github.com/NREL/SAM/issues/1722

sjanzou commented 4 months ago

Test file ITC_basis_reduction.zip

Test with no IBI

Test with IBI with no basis reduction

Test with IBI with federal and state basis reduction

Test with federal and state taxable IBI and federal and state basis reduction

brtietz commented 4 months ago

The ITC amounts now have the behavior that I'd expect, but I'm a little concerned that IBI isn't showing up in purchase of property:

Would some of the test processes from https://github.com/NREL/ssc/issues/1047 be relevant here?

sjanzou commented 4 months ago

The ITC amounts now have the behavior that I'd expect, but I'm a little concerned that IBI isn't showing up in purchase of property:

Would some of the test processes from #1047 be relevant here?

I think much more testing is in order here and for all of the financial markets.

I am leaning towards moving issue https://github.com/NREL/SAM/issues/1477 and https://github.com/NREL/SAM/issues/1722 to patch 2 - any objections?

brtietz commented 4 months ago

@sjanzou Agreed. The milestones for those issues have been changed to patch 2

brtietz commented 1 week ago

Closing PR as we're addressing this in https://github.com/NREL/ssc/pull/1178