Apply diffuse self-shading in all racking/shade-behavior scenarios

NREL / ssc

SAM Simulation Core (SSC) contains the underlying performance and financial models for SAM

BSD 3-Clause "New" or "Revised" License

79 stars 85 forks source link

Apply diffuse self-shading in all racking/shade-behavior scenarios #236

Closed caseyzak24 closed 5 years ago

caseyzak24 commented 5 years ago

Currently diffuse self-shading in SAM is applied as shown in the following graph

where the green scenarios have it applied and the blue scenarios do not.

However, the current diffuse self-shading model, which is based on a simple 2-D unlimited sheds geometry, seems applicable as an approximation to all scenarios. In particular for backtracking SAT systems, diffuse shading becomes important due to the higher tilt angles experienced and we've seen it contribute up to a 2% loss to energy production.

janinefreeman commented 5 years ago

Thanks for creating the issue with all the helpful details for this, @caseyzak24 ! The SAM team agrees that diffuse self-shading should be applied in the blue scenarios as well. If you get a chance to make some improvements (or if anyone else is interested in tackling it!), let us know!

caseyzak24 commented 5 years ago

@janinefreeman I am currently working on this issue and I think I have it implemented, just working out a few kinks. I will submit a PR when it is complete.

janinefreeman commented 5 years ago

Awesome! Looking forward to it! Thanks @caseyzak24 !

janinefreeman commented 5 years ago

Closed in 27a1793664c34b64b06d06ba055579353f4b55fc