search

NREL / tyche

https://nrel.github.io/tyche-docs/
MIT License
3 stars 1 forks source link

to discuss: Change "Module" in functions dataset to "Model"? #88

Closed rjhanes closed 1 year ago

rjhanes commented 2 years ago

@TJTapajyoti , @SamBaldwinDOE , and @clhughes :

This is what the functions dataset currently looks like:

<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

Technology | Style | Module | Capital | Fixed | Production | Metrics | Notes -- | -- | -- | -- | -- | -- | -- | -- Biorefinery v1 | numpy | tutorial_biorefinery | capital_cost | fixed_cost | production | metrics |  

I suggest we rename the "Module" column to "Model". It's technically correct that every technology is its own module within Tyche, but I think the nomenclature is confusing.

This is a super-minor, non-functional change, so if there are no objections I'll implement this in time for our Q3 deliverable release.

tjlca commented 2 years ago

I agree

SamBaldwinDOE commented 2 years ago

Works for me.

On Fri, Jun 17, 2022 at 5:53 PM Rebecca Hanes @.***> wrote:

@TJTapajyoti https://github.com/TJTapajyoti , @SamBaldwinDOE https://github.com/SamBaldwinDOE , and @clhughes https://github.com/clhughes :

This is what the functions dataset currently looks like: Technology Style Module Capital Fixed Production Metrics Notes Biorefinery v1 numpy tutorial_biorefinery capital_cost fixed_cost production metrics

I suggest we rename the "Module" column to "Model". It's technically correct that every technology is its own module within Tyche, but I think the nomenclature is confusing.

This is a super-minor, non-functional change, so if there are no objections I'll implement this in time for our Q3 deliverable release.

— Reply to this email directly, view it on GitHub https://github.com/NREL/tyche/issues/88, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK2OV5ZBB2WXZO5LQBA4FOLVPTXW5ANCNFSM5ZDQXZCQ . You are receiving this because you were mentioned.Message ID: @.***>

rjhanes commented 1 year ago

Closed in PR #108