search

NRGI / ResourceProjects.org

MIT License
4 stars 0 forks source link

UK CH new data (Fresnillo) did not load proper after reload of all data #132

Closed davidmihalyi closed 8 years ago

davidmihalyi commented 8 years ago

There is finally new data on the API (the second company after Shell), but it does not seem to have loaded on RP.org after a reload. Fresnilllo PLC : it seems like API created a record but it is empty. http://resourceprojects.org/company/5762a6b595dfcf0f006cfa39 vs
https://extractives.companieshouse.gov.uk/api/company/06344120/year/2015/xml

mattfullerton commented 8 years ago

Should be fixed. Related question: should we disable the "only one import allowed" function for CH? Or shall we just ignore that annoyance until unloading function comes?

davidmihalyi commented 8 years ago

we could even enable all re-imports, right? From what I remember, we blocked it for launch, because we worried it might cause troubles, but should be fine if used carefully (and not for editing existing entries)

davidmihalyi commented 8 years ago

ah, I just saw your email, arguing opposite. fine with me to enable reload of UK CH with click but knowing we should be careful

davidmihalyi commented 8 years ago

@mattfullerton : can we get a trial run on "disable one import function for CH-API" and see how it performs?

mattfullerton commented 8 years ago

Yes, but as this is making the "do I allow import button" logic quite complex I'm going to move it out of the template and into the Angular controller, so not a quick fix. Will try to squeeze it in tomorrow.

mattfullerton commented 8 years ago

This is now fixed in dev. Not sure what the current CI process is for allowing you to play with that. The fix is temorary; once we have the data cleaning workflow finished I'll allow API-style imports to always be imported if the last import was cleaned. So the workflow will be import-clean-import-clean etc. for APIs and import-unload-import-unload-import-clean-unload-import etc. for Google Sheets.

davidmihalyi commented 8 years ago

Great, thanks!