Documents display / grouping

[charlesyoung]

https://docs.google.com/document/d/1_Mkx7BRUWFhuKzrh-XWIC9D6S1ZIClQBxMZrO0Dr6bE/edit#

Document display and grouping specs to be added here.

cc @jedm @SamCCSI @anjesh

[SamCCSI]

Confirming I'm on the same page as @jedm for this ticket. Thanks @charlesyoung for flagging.

[charlesyoung]

Thanks @SamCCSI

@man-git007 so its just the 1 outstanding issue noted above.

[man-git007]

@charlesyoung We have made the changes and deployed in staging server. The main contract summary page will look like this

cc @SamCCSI

[charlesyoung]

Thanks, looks good.

@jedm can you please do 1 last check before we update the prod site. See below, that's on the main docs summary page.

@man-git007 not sure if you have to load a JavaScript file from cache like you did with the hide advance search bar because I have to use an incognito window to view your changes.

[jedm]

Noting 2 small inconsistencies before we push to prod.

1) In Associated Docs, Main Contract is displayed with words "(Main Contract") after: https://staging.resourcecontracts.org/contract/ocds-591adf-8560734374

In Main Contract, the Main Contract does not have the words "(Main Contract"): https://staging.resourcecontracts.org/contract/ocds-591adf-3419068261

Should be consistent.

2) In this main contract Summary Page, the big button linking to "View Document" (upper right) is missing: https://staging.resourcecontracts.org/contract/ocds-591adf-3419068261

[man-git007]

@jedm Issue 1 has been resolved and deployed to the staging server. As for issue 2, the "View Document" button to be shown, the contracts should have published pdf pages from admin side. Since it has been published now it shows. https://staging.resourcecontracts.org/contract/ocds-591adf-3419068261

[charlesyoung]

Thanks @man-git007

Looks good, @jedm can we deploy to Prod?

cc @SamCCSI

[jedm]

OK to deploy! @man-git007

[charlesyoung]

@man-git007 will you be able to deploy to the prod site this week?

[man-git007]

@charlesyoung It has been deployed in prod site. For now, we have to manually go through /gsearch URL since we don't have any UI button for this. Since this feature is to replace our current search feature in rc and olc subsites. So, this URL will change after we finish the home page design and implement recent docs. Also, We have removed the score label in contract lsiting

cc @anjesh @jedm

[charlesyoung]

Thanks @man-git007

Confirm that the manual URL update works on the Prod site.

Not sure if this is because of my connection but I found the display speed slow when clicking on below link. @jedm can you possibly test?

https://www.resourcecontracts.org/gsearch?q

I should know this and I know it has been discussed but why don't we show the search total on the top right anymore? Its it due to the filtering?

[charlesyoung]

Can we please ensure that the grouping format is replicated on mobile devices. Below shows a main doc with 2 supporting docs. It’s however not obvious because the supporting docs aren’t indented.

[SamCCSI]

https://staging.resourcecontracts.org/search/recent

Confirming that the reason the other 2 associated documents aren't displayed here is only because they aren't "recent" docs?

(E.g. if I did a search for "Lefa", all 4 docs would appear without the "view [x] other docs..."?)

[charlesyoung]

@jedm just confirming that the main docs also need to be arranged chronologically.

Not yet sure which order (old to new or new to old) NRGI want to display the docs but just confirming that the main docs should also be listed chronologically like the supporting docs currently do.

cc @anjesh

[jedm]

@man-git007 I think there may be conflicts between the display functions for free-text search results and the display functions for recent. These conflicts may include:

• Clustering and "view # more" function
• Sort order of main contracts
• Sort order of associated docs

@charlesyoung: Agree that gsearch is slow but I assume it is because of staging.

We should confirm with YI that the clustering and "# more documents" functions should work the same way for Recent as they do for other searches. This probably requires a live phone call.

Thank you,

Jed

cc @anjesh

[SamCCSI]

Change needed: Searches that only produce main docs don’t currently show “show X docs” link when those main docs have associated docs (that don't correspond to the search). But they need to.

Example: https://staging.resourcecontracts.org/search/group?q=dinguiraye+serem&country%5B%5D=GN&company_name%5B%5D=Nordgold

[bizaybsnt]

Change needed: Searches that only produce main docs don’t currently show “show X docs” link when those main docs have associated docs (that don't correspond to the search). But they need to.

Example: https://staging.resourcecontracts.org/search/group?q=dinguiraye+serem&country%5B%5D=GN&company_name%5B%5D=Nordgold

@SamCCSI We have fixed this issue. Please check.

We should confirm with YI that the clustering and "# more documents" functions should work the same way for Recent as they do for other searches. This probably requires a live phone call.

@jedm We'd like to confirm that we are using the same logic for the clustering and "# more documents" functions for recent contract and group search.

Sort order of main contracts

For now, the default sorting order for main contracts for group search is based on the weightage of the document and sort order for recent search is based on the published date.

Sort order of associated docs

The sorting order for associated docs is based on signature year for both recent and group search.

We are ready to close this issue. Please mention if any changes is needed.

cc: @anjesh @man-git007

[SamCCSI]

My requested change looks good, thanks! See my comment on #1262 re visual design request.

[man-git007]

@SamCCSI @charlesyoung We have implemented the grouping and recent contract listing in the live server. This feature is related to the #1225 Homepage redesign. It wont be reflected in subsite for now. But the functionality has been implemented.

I suggest this issue be closed.

cc @anjesh @bizaybsnt

[charlesyoung]

Thanks @man-git007

I however cannot see the updates after doing a hard Chrome refresh and testing it through an incognito window.

Let's please leave this ticket open until the subsites are also done.

[SamCCSI]

I'm also not seeing the changes on the openlandcontracts.org live site

[charlesyoung]

@man-git007 just checking if this has been deployed on the RC and OLC prod sites.

[man-git007]

@charlesyoung @SamCCSI Since the recent and grouping was associated with #1225, it was not showing in the live server. We have fixed the issue and deployed it in the staging site of both rc and old. Could you please verify. The links are below:

https://staging.resourcecontracts.org/search/group?q=&recent=1 https://staging.resourcecontracts.org/search/group https://staging.openlandcontracts.org/search/group?q=&recent=1 https://staging.openlandcontracts.org/search/group

cc @bizaybsnt

[SamCCSI]

Thanks!

[man-git007]

@charlesyoung @SamCCSI If all good. We will deploy it to live server

cc @bizaybsnt

[charlesyoung]

@man-git007 the staging site has lost the grouping again, can you please look at this. NRGI might want to change the chronological ordering which unfortunately this will result in a code branch.

[man-git007]

@charlesyoung There are not any links to recent and group contracts on the site for now. Since the links are in #1225 issue. For now, we have to manually hit the link in the URL. Is there something I am missing?

cc @bizaybsnt

[charlesyoung]

NRGI is trying to decide which chronological ordering to follow and they have asked so see a site to where its presented.

[man-git007]

@charlesyoung Are these the link you are suggesting?

RC recent contracts https://staging.resourcecontracts.org/search/group?q=&recent=1 RC group contracts https://staging.resourcecontracts.org/search/group OLC recent contracts https://staging.openlandcontracts.org/search/group?q=&recent=1 OLC group contracts https://staging.openlandcontracts.org/search/group

[man-git007]

@charlesyoung @SamCCSI Are we all clear to deploy this in live server.

[charlesyoung]

Nope, as noted above NRGI is trying to decide which chronological ordering to follow

[charlesyoung]

@anjesh a question from NRGI re the supporting documents chronological ordering.

'Not sure how technically feasible this would be, but couldn’t we have it both ways? If we develop a button that users could use to change the sort order from newest first to oldest first then the user can choose how they view the contracts.'

cc @SamCCSI @jedm

[charlesyoung]

Ignore above.

If @SamCCSI and @jedm are happy please deploy to the production sites.

[man-git007]

@SamCCSI and @jedm Are we good to go?

[SamCCSI]

Waiting on Jed for response to this comment: https://github.com/NRGI/resourcecontracts.org/issues/1262#issuecomment-609773580

Once @jedm weighs in it will be ready to deploy. Thanks @man-git007

[charlesyoung]

@jedm can you please comment on above question. Thanks

[jedm]

Hello @man-git007. Thank you for your patience with our last decisions! I have responded to the comment in #1262 and Charles has confirmed today with @anjesh that the order of Associated Documents is ok. cc @charlesyoung @SamCCSI

[charlesyoung]

@man-git007 can you push this to the Prod site when you have time. Thanks

[anjesh]

@jedm @charlesyoung i forgot to mention last time that this will also push recent documents checkbox to the production. And we will update the RC/OLC current search box to grouped documents list and including recent document checkbox. Please confirm. @man-git007 will then push it.

[charlesyoung]

Sounds good. @jedm?

cc @SamCCSI

[jedm]

This is good news. Sounds good to me.

On Tue, Apr 14, 2020 at 5:52 AM Charles Young notifications@github.com wrote:

Sounds good. @jedm https://github.com/jedm?

cc @SamCCSI https://github.com/SamCCSI

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NRGI/resourcecontracts.org/issues/1096#issuecomment-613341693, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQNZQFZ4PZZIVFNYOZEJUDRMQW4FANCNFSM4ESYSQBQ .

-- Jed Miller | @jedmiller http://twitter.com/jedmiller m +1.917.584.2349 | s @jedbmiller www.jedmiller.com

[charlesyoung]

Thanks @jedm

@anjesh @man-git007 can this be deployed?

[man-git007]

@charlesyoung It has been deployed in live server. Will also close the recent API issue.

cc @jedm @SamCCSI @anjesh

[charlesyoung]

Thanks. I'm going to leave this open until I can see it working. Tried to refresh Chrome and use an incognito window and it doesn't show the grouping.

[SamCCSI]

i'm also not seeing grouping or recent docs field on OLC or RC

[bizaybsnt]

We have updated the grouping feature enabled from the home page and header search bar.

@charlesyoung @SamCCSI Please let us know if anything is missing from our side.

Thanks.

[SamCCSI]

Working very nicely now on OLC. Thanks!

On Thu, Apr 16, 2020 at 2:17 AM Bijay Basnet notifications@github.com wrote:

We have updated the grouping feature enabled from the home page and header search bar.

@charlesyoung https://github.com/charlesyoung @SamCCSI https://github.com/SamCCSI Please let us know if anything is missing from our side.

Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NRGI/resourcecontracts.org/issues/1096#issuecomment-614438016, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCQZ6YHA4HXHXH7I3XZSYTRM2PIHANCNFSM4ESYSQBQ .

[charlesyoung]

@man-git007 @bizaybsnt thanks the grouping looks good. Just 2 points.

• Please remove the 'Associated document' text

• Has this functionality impacted the sites speed? Two users contacted me over the weekend noting that the site has become unbearably slow.
• Also as noted below (from the requirements doc) can all the docs be displayed in reverse chronological order (signature year).

cc @SamCCSI @jedm

[jedm]

Regarding the below note from @charlesyoung, this relates to the view when no search term has been entered, and the All Documents view.

Also as noted below (from the requirements doc) can all the docs be displayed in reverse chronological order (signature year).

[charlesyoung]

@man-git007 @bizaybsnt will it be possible to apply above minor changes so that we can close this ticket. Thanks