NRGI / resourcecontracts.org

Resource Contracts
http://resourcecontracts.org
GNU General Public License v2.0
16 stars 9 forks source link

Updates to country sites as per new design/document grouping structure #1299

Closed anjesh closed 4 years ago

anjesh commented 4 years ago
charlesyoung commented 4 years ago

@anjesh how easy will it be to do below for the country home pages based on the new design?

@SamCCSI does CCSI have any country sites?

nirvanalama commented 4 years ago

@charlesyoung @man-git007 @sweta-shrestha New Country page design https://www.figma.com/file/OK1BSOpfKTokEoBZYQCXss/RC__UI_v2?node-id=578%3A108

man-git007 commented 4 years ago

@SamCCSI Can you provide the staging or production country site for OLC?

charlesyoung commented 4 years ago

Thanks @nirvanalama

I would like to mimic the new home page design as much as possible.

man-git007 commented 4 years ago

@charlesyoung Don't we need recent documents for country site? If yes we will need that Recent Document card in homepage. If not then we will show only the Document and Resources card. @SamCCSI Could you also provide some feedback regarding the new country site?

cc @nirvanalama

charlesyoung commented 4 years ago

I don't want the Recent Docs box on the country sites. It works on the generic site but for instance we have not published a contract for Sierra Leone for over a year so I don't want the Recent Docs box to reflect 0.

Are there any OLC country sites?

SamCCSI commented 4 years ago

@SamCCSI Can you provide the staging or production country site for OLC?

OLC doesn't have any country sites, so we wont offer feedback. But very happy to answer any questions.

nirvanalama commented 4 years ago

@charlesyoung @SamCCSI @man-git007 Here is the updated design https://www.figma.com/file/OK1BSOpfKTokEoBZYQCXss/RC__UI_v2?node-id=578%3A108

man-git007 commented 4 years ago

@charlesyoung Is the design provided OK? If all good we will start working on it.

charlesyoung commented 4 years ago

Can you please also look at replacing the top half of the page with the latest design so that we carry the flexibility of updating text, etc.

man-git007 commented 4 years ago

@charlesyoung Regarding the text updates for country sites, it might take some time as we had developed this feature considering the RC and OLC sites only.

charlesyoung commented 4 years ago

Can you note use most of the code developed for the RC and OLC sites?

man-git007 commented 4 years ago

@charlesyoung We have deployed the new design in the staging country site. Please check the other country site. For the text to be updated on the homepage of the ivory country site, follow the link. Similarly for the other country sites also https://staging.guinea.resourcecontracts.org/admin/text

cc @sweta-shrestha

charlesyoung commented 4 years ago

Many thanks @man-git007, commnets below.

image

man-git007 commented 4 years ago

@charlesyoung The changes you had mention have been done and deployed in the staging server. https://staging.ivorycoast.resourcecontracts.org/ https://staging.guinea.resourcecontracts.org/

cc @sweta-shrestha

charlesyoung commented 4 years ago

Thanks, couple things.

  1. Can somehow highlight the Guinea language links image

  2. Also the IC site doesn't look right. image

man-git007 commented 4 years ago

@charlesyoung have just deployed fixes in staging server. Please do hard refresh after a while

cc @sweta-shrestha

charlesyoung commented 4 years ago

Which fixes?

man-git007 commented 4 years ago

@charlesyoung Please check the staging site. Is there anything missing?

jedm commented 4 years ago

Hi @charlesyoung. I would suggest adding a transparency over the homepage image so that it is faded by 15-25%. This will make it easier to read the words and controls.

On Wed, Jul 29, 2020 at 7:08 AM Manish Pradhan notifications@github.com wrote:

@charlesyoung https://github.com/charlesyoung Please check the staging site. Is there anything missing?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NRGI/resourcecontracts.org/issues/1299#issuecomment-665600589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQNZQDXJXDLM3ADLOT5VE3R577MJANCNFSM4N3JQUHA .

-- Jed Miller | @jedmiller http://twitter.com/jedmiller m +1.917.584.2349 | s @jedbmiller www.jedmiller.com

charlesyoung commented 4 years ago

Thanks @man-git007

Thanks @jedm, that could work especially for the Guinea site where its difficult to read all the text. @man-git007 can you look at applying a 15-25% transparency over the homepage image?

man-git007 commented 4 years ago

@charlesyoung The background transparent has been done. Please verify. If all good we can deploy to live country site.

cc @sweta-shrestha @anjesh

charlesyoung commented 4 years ago

Great. Please deploy to the IC and Guinea prod country sites.

Also note that the Tunisia and Zambia sites also need to be updated. Don't worry about applying to the staging sites first, you can do it straight on the Prod sites.

@candrei is busy working on the DRC site issues that has the code on the Ministries domain. Can we update the DRC site as well?

charlesyoung commented 4 years ago

One change please. The map box shouldn't be clickable.

image

man-git007 commented 4 years ago

@charlesyoung Do we need to remove the hover effect from map card? Screenshot from 2020-07-30 13-31-46

charlesyoung commented 4 years ago

Yes please. It serves no purpose and doesn't open a new link. The hover and clickability needs to be removed from the map.

man-git007 commented 4 years ago

@charlesyoung The country sites have been upgraded. Need to add text in all country homepage.

charlesyoung commented 4 years ago

Thanks. I've added text to the sites. Will close this ticket once the DRC site has been updated.

charlesyoung commented 4 years ago

I just noticed the placement of the Recent Docs tick box. Can it be moved in line with the Tagged Contracts Only tick box? Also, the Annotation Category and Annotated Contracts Only labels need to change to Key Clauses and Tagged Contracts Only.

Also are updates to #1096 being applied to the country sites?

image

man-git007 commented 4 years ago

@charlesyoung The label has been updated and the checkbox alignment also has been fixed.

charlesyoung commented 4 years ago

Many thanks

man-git007 commented 4 years ago

@charlesyoung Can we close this issue?