NRGI / resourcedata.org

CKAN
3 stars 1 forks source link

Change Analysis URL path #184

Closed t-morrison closed 7 years ago

t-morrison commented 7 years ago

Replace "Pages" with "Analysis". Depending on ease of implementation.

image

mattfullerton commented 7 years ago

I'm fairly certain this is easy to do; will get back to you if not

mattfullerton commented 7 years ago

@moman822 This is almost done now on staging. You'll need to change your links in the landing page and I still need to change the menu and the title on the page for the second link below

But, the hard work is done: https://staging.resourcedata.org/analysis/analysis-landing-page https://staging.resourcedata.org/analysis/

I've tried to only change links for public facing/linked-to pages. Its done properly so it can be accepted back into ckanext-pages (the idea of an alternative name for pages as a configuration property for CKAN)

t-morrison commented 7 years ago

Not knowing what you plan to change on the menu and title of /analysis, these are my thoughts/concerns:

Here is /analysis/home (changed analysis/analysis-landing-page to analysis/home) image

If you click the second Analysis link on the breadcrumb bar, it stays, as expected.

If you click the first Analysis link, it takes you here, the "real" home page for this section of the website. This is not desirable. image

I don't imagine it is feasible or worth spending time on to hack what is now /analysis/home into just /analysis and then have subsequent links to pages be also /analysis/first-analysis-page (because what is now analysis/home is really a page made with the standard CKAN 'Pages' feature branching off /analysis).

My original desire was to have analysis/home so I could customize the landing page that users would see. Is it possible instead to insert some minimal customization into the default CKAN "Pages" page? Just a paragraph or two, plus the breadcrumbs bar, and have pages created under it with the subsequent breadcrumbs?

Hopefully this will

That page is now staging.resourcedata.org/analysis and looks like this to outside users: image

mattfullerton commented 7 years ago

Would it be enough if I just hack the breadcrumbs bar a little bit so that Analysis (top level) always goes to analysis/home, and that if we're on /home, we don't show that as a sub-option, and only do that for other pages?

I can probably also tell /analysis/ to give a 404 for people not logged in and perform as normal (i.e. managers view of what pages exist) for logged in users.

i.e. /analysis/ - 404, no breadcrumb /analysis/home - Breadcrumb is "Analysis" /analysis/some-other-interesting-viz - Breadcrumb is "Analysis" -> "Some Interesting Viz"

and so on

Its obviously a deviation from the core extension, but... that's what open source is for...

mattfullerton commented 7 years ago

I've gone ahead and made those changes on staging. You need to update the internal links in pages to /analysis instead of /pages, but overall it seems to be working nicely. If you're happy, then we can close this.

t-morrison commented 7 years ago

@mattfullerton this looks good.

t-morrison commented 7 years ago

@mattfullerton This doesn't look good on production on second thought. The "Analysis" link on the toolbar needs to be updated:

It points to this (404): https://www.resourcedata.org/pages/analysis-landing-page

Instead of this (good): https://www.resourcedata.org/analysis/home

mattfullerton commented 7 years ago

That's already done on staging