NRGI / resourceprojects.org-frontend

1 stars 1 forks source link

Filters on Country page #142

Open caprenter opened 9 years ago

caprenter commented 9 years ago

Ben can you please take a look at passing through Filter options on e.g: http://16-country-page-template.lodspeakr-live.nrgi-dev2.default.opendataservices.uk0.bigv.io/country/AO.html

Bjwebb commented 9 years ago

There are now concession type filters on http://lodspeakr-live.nrgi-dev2.default.opendataservices.uk0.bigv.io/country/AO

@caprenter is this one for you to tidy up and take further, or do you want more input from me?

caprenter commented 9 years ago

If we can get the status filter going that would be good, but not necessary. Drop the company group filter.

Make it filter the whole page

caprenter commented 9 years ago

I've just looked at this again, and the behaviour is unclear.

Selecting a commotdity type and filtering it works, but on e.g. Angola there are no Mining projects, so it just gives a blank screen.

I'd kind of expect that 'no filters' would give the same result as 'both filters' on but it doesn't.

I'm going to make a pull request with these options removed from the interface

davidmihalyi commented 9 years ago

Are you dropping the filter? Or maybe can be a toggle between mining/oil/both?

Sent from mobile; pls excuse brevity and typos.

On 22 Oct 2015, at 21:40, caprenter notifications@github.com<mailto:notifications@github.com> wrote:

I've just looked at this again, and the behaviour is unclear.

Selecting a commotdity type and filtering it works, but on e.g. Angola there are no Mining projects, so it just gives a blank screen.

I'd kind of expect that 'no filters' would give the same result as 'both filters' on but it doesn't.

I'm going to make a pull request with these options removed from the interface

Reply to this email directly or view it on GitHubhttps://github.com/NRGI/resourceprojects.org-frontend/issues/142#issuecomment-150349989.

caprenter commented 9 years ago

We have dropped this for now - for reasons given.

I think this is sensible at this stage - to get it in safely and properly would take a bit of more dedicated time and I worry about rushing it.