NRGI / rgi-assessment-tool

MEAN build of RGI 2015 assessment tool
MIT License
5 stars 1 forks source link

External review trigger process #203

Open ahasemann opened 8 years ago

ahasemann commented 8 years ago

Admin: Post peer review and approving all answers, can only send assessment ot the researcher or reviewer, nexternal reviewer is not given as an option even though an external reviewer has been assigned to the assessment

byndcivilization commented 8 years ago

We need to figure out the best way to do this. Since we are letting multple external reviewers access and add input on assessments in theory before an assessment is even done, it doesnt make a ton of sense to route it in the same way as assessment state based routing. In other words, when an assessment is passed to from a researcher to admin, it is under review, when its passed back to a researcher, its under researcher review. External reviews arent really the same beast since at least in theory, an assessment could be both under reviewer review and external review from multiple parties. Right now we have a threshold of 80% complete. We can make a trigger that fires off an email to assigned external reviewers when that threshold is reached. We can also set that trigger to fire off when an external reviewer is assigned to an assessment that has already reached that state.

ahasemann commented 8 years ago

Just to flag that the 80% will only apply to assessments where the researcher is taking a long time to complete the questionnaire, we will aim to have the majority 100% peer reviewed before sending them on to additional reviewers (those include both staff and external reviewers)

byndcivilization commented 8 years ago

does this mean that we will cut off reviewers that are taking a long time or do we forsee having peer reviewers and external reviewers working in tandem?

ahasemann commented 8 years ago

Ideally they would be working in tandem - although this depends whether this is possible to do with the tool workflow

byndcivilization commented 8 years ago

Anything is possible. Anything... Let me do some reconfiguring this weekend.

ahasemann commented 8 years ago

Staff reviewers (2x) and external (govt reviewers) would also be working in tandem

ahasemann commented 8 years ago

Haha, ok

byndcivilization commented 8 years ago

External reviewers for sure. The way things are currently set, hits that requirement, but it gives a standard 80% threshold across assessments. So the second a peer reviewer completes 80%, an external reviewer would have access. However, they would only see answers that are marked approved by admin.

ahasemann commented 8 years ago

Ok, if it's only possible to have either 80% or 100% as threshold, 80 would be better, but if it is at all possible to have that be flexible that woule be great. If not, we'll work around it

byndcivilization commented 8 years ago

I guess a way would be to set the threshold at the assessment level but that doesnt seem any better as it would require all sorts of hassle to maintain.

ahasemann commented 8 years ago

Yea, I can see how this could get messy easily

byndcivilization commented 8 years ago

Proposed solution: