NRL-Plasma-Physics-Division / turbopy

A lightweight computational physics framework, based on the organization of turboWAVE. Implements a "Simulation, PhysicsModule, ComputeTool, Diagnostic" class hierarchy.

https://turbopy.readthedocs.io/

Creative Commons Zero v1.0 Universal

10 stars 18 forks source link

149 output utility #150

Closed arichar6 closed 4 years ago

arichar6 commented 4 years ago

Pull Request

Description

Create new API and base class for OutputUtilities

This pull request addresses #149

Checklist

The following items have been checked for this PR:

[ ] Conforms to PEP8 style standards (check with pylint, flake8, or similar)
[x] Code is documented with docstrings, or docstrings have been updated as appropriate
[ ] New unit test/integration test have been added to check new code
[x] All existing tests still pass

arichar6 commented 4 years ago

Thanks for the review. I've made a slight change, adding a new ABC method that should be useful for your PR #148. I've added write_data to the OutputUtility. You should be able to just call that method at some new interval. You don't have to worry about the details, as those will be taken care of in the concrete OutputUtility.

arichar6 commented 4 years ago

@AOstenfeld I'm going to go ahead and merge this, since I want to start using the HistoryDiagnostic for other things.