NRL-Plasma-Physics-Division / turbopy

A lightweight computational physics framework, based on the organization of turboWAVE. Implements a "Simulation, PhysicsModule, ComputeTool, Diagnostic" class hierarchy.

https://turbopy.readthedocs.io/

Creative Commons Zero v1.0 Universal

10 stars 18 forks source link

[WIP]: Resource warnings #167

Closed ndisner closed 3 years ago

ndisner commented 3 years ago

Pull Request

Description

This PR is currently using python's any() function as a boolean to check if the resources in the simulation are found. I think this could be done better and any brainstorming is welcomed!

This pull request addresses # \ Fixes #10

Checklist

The following items have been checked for this PR:

[ ] Conforms to PEP8 style standards (check with pylint, flake8, or similar)
[ ] Code is documented with docstrings, or docstrings have been updated as appropriate
[ ] New unit test/integration test have been added to check new code
[ ] All existing tests still pass

arichar6 commented 3 years ago

Thanks for thinking about this. I suspect that more substantial changes will need to be made in order to get this to work correctly, though. The inspect_resource method gets called multiple times during setup, so there will be "missing" resources on many of those individual calls. I'd be happy to have a brainstorming session about this sometime. Maybe some of the interns would also like to be involved (@gracetangg, interested?). We should schedule something on Teams.

gracetangg commented 3 years ago

@arichar6 Sounds good I'd be interested!

arichar6 commented 3 years ago

I think this is no longer required, given the new sharing api in #170