search

NRL-Plasma-Physics-Division / turbopy

A lightweight computational physics framework, based on the organization of turboWAVE. Implements a "Simulation, PhysicsModule, ComputeTool, Diagnostic" class hierarchy.
https://turbopy.readthedocs.io/
Creative Commons Zero v1.0 Universal
10 stars 18 forks source link

Overly complex method #173

Closed arichar6 closed 3 years ago

arichar6 commented 3 years ago

The Simulation.read_diagnostics_from_input method is overly complex. This makes it hard to maintain and potentially extend: https://github.com/NRL-Plasma-Physics-Division/turbopy/blob/67907c575a40a792b3e4634f12b2259ff3632b04/turbopy/core.py#L248

I think that the main problem with this method is that it mixes the "what" with the "how" way too much.

arichar6 commented 3 years ago

I'm satisfied with the improvements in PR #175