NRL-Plasma-Physics-Division / turbopy

A lightweight computational physics framework, based on the organization of turboWAVE. Implements a "Simulation, PhysicsModule, ComputeTool, Diagnostic" class hierarchy.

https://turbopy.readthedocs.io/

Creative Commons Zero v1.0 Universal

10 stars 18 forks source link

Reduce complexity of read_diagnostics_from_input method #175

Closed arichar6 closed 3 years ago

arichar6 commented 3 years ago

Pull Request

Refactor the read_diagnostics_from_input method, to reduce code complexity.

This pull request addresses #173

Checklist

The following items have been checked for this PR:

[x] Conforms to PEP8 style standards (check with pylint, flake8, or similar)
[ ] Code is documented with docstrings, or docstrings have been updated as appropriate
[ ] New unit test/integration test have been added to check new code
[x] All existing tests still pass

arichar6 commented 3 years ago

@gracetangg and @AOstenfeld, since you pointed out that the read_diagnostics_from_input method is overly complex, I thought I'd start doing a refactor of that method. I'm tagging you here in case you want to contribute, or just follow along.