NRL-Plasma-Physics-Division / turbopy

A lightweight computational physics framework, based on the organization of turboWAVE. Implements a "Simulation, PhysicsModule, ComputeTool, Diagnostic" class hierarchy.
https://turbopy.readthedocs.io/
Creative Commons Zero v1.0 Universal
10 stars 18 forks source link

API for sharing data is confusing #178

Closed arichar6 closed 3 years ago

arichar6 commented 3 years ago

Data sharing in turboPy

Right now, the code needed for sharing data between modules, diagnostics, etc is a bit confusing. Overloading of some methods is required, and the method names a hard (at least for me) to keep straight... there is exchange_resources, publish_resource, and inspect_resource. Which have to be overloaded in order to share data, and what code goes where?

We have had some discussions about this already. See PR #170. I'm making this issue as a place to discuss this problem.

arichar6 commented 3 years ago

Closed with PR #170