NRL-Plasma-Physics-Division / turbopy

A lightweight computational physics framework, based on the organization of turboWAVE. Implements a "Simulation, PhysicsModule, ComputeTool, Diagnostic" class hierarchy.

https://turbopy.readthedocs.io/

Creative Commons Zero v1.0 Universal

10 stars 18 forks source link

[WIP] Fix 170 merge with main #181

Closed carolinegsun closed 3 years ago

carolinegsun commented 3 years ago

Pull Request

Description

Explain any proposed changes here.

This pull request addresses #170 Fixes #

Checklist

The following items have been checked for this PR:

working on build fail

[ ] Conforms to PEP8 style standards (check with pylint, flake8, or similar)
[ ] Code is documented with docstrings, or docstrings have been updated as appropriate
[ ] New unit test/integration test have been added to check new code
[ ] All existing tests still pass

arichar6 commented 3 years ago

So I spent some time trying to figure this out, and write some of the tests for new and old API. I've merged the changes from the main branch into the #170 PR.

So far I can get the V1+V1 and V2+V2 sharing tests to pass for PhysicsModules. We still need tests for the Diagnostics. But the V1/V2 and V2/V1 tests are failing right now. I'm open to suggestions on whether or not it is worth the effort to get them to work.

arichar6 commented 3 years ago

Thanks for all your feedback and help with this. I think the new sharing api turned out nicely!