search

NRLMMD-GEOIPS / geoips

Main Geolocated Information Processing System code base with basic functionality enabled.
https://nrlmmd-geoips.github.io/geoips/
Other
15 stars 11 forks source link

Fix handling of valid python identifiers in schema #199

Open jsolbrig opened 1 year ago

jsolbrig commented 1 year ago

Requested Update

Description

I temporarily disabled checking of valid python identifiers in plugins and schema. I disable this by modifying geoips/schema/bases/valid_identifier.yaml to comment out the pattern test.

The pattern test should be renabled and all failing instances of this should be tracked down. Also, the tests should be renabled by editing tests/test_pytest/test_plugin_schema/bad/bases/valid_identifier.yaml.

While doing this, we should consider whether name in yaml plugins should always be a valid python identifier and, if so, how to modify those that don't currently conform. Examples of this are most prevalent in the products and product_defaults plugins, where many of the names start with a number (e.g. name: 19H).

biosafetylvl5 commented 6 months ago

We need someone to go in and look into this if this is going to be implemented. Not a high priority right now.

biosafetylvl5 commented 6 months ago

Related to the order based procflow and yaml schema implementations