NRLMMD-GEOIPS / geoips

Main Geolocated Information Processing System code base with basic functionality enabled.
https://nrlmmd-geoips.github.io/geoips/
Other
14 stars 11 forks source link

LaTeX not listed as a dependency for building docs in installation instructions #466

Closed biosafetylvl5 closed 5 months ago

biosafetylvl5 commented 6 months ago

Latex not listed as a dependency for building docs in installation instructions

Background

Alternative Solutions

Environment

Output:

ERROR: latex must be installed in order to create pdf documentation.
  try 'module load latex'
mindyls commented 6 months ago

@biosafetylvl5 Note if you call build_docs.sh with the "html_only" argument, it will not attempt to build the pdf. As in the call in "test_all.sh":

https://github.com/NRLMMD-GEOIPS/geoips/blob/4d260ed31460a6646b3c325bf969799baad66a0e/tests/test_all.sh#L34

For creating documentation, I think html_only is sufficient/preferably, so you don't need to install latex. It should definitely be documented what the requirements are - but I would tend towards building with "html_only" for general purpose use (unless we're actually deploying the documentation or performing a full test of the doc build).

biosafetylvl5 commented 6 months ago

Perhaps I can add this to the docs, but also update the error message to direct users to either install latex/build html only. What do you think? @mindyls

mindyls commented 6 months ago

Yes that sounds good, thanks!

biosafetylvl5 commented 6 months ago

Awesome! Thanks for helping to bring me up to speed on the build process