Closed evrose54 closed 3 weeks ago
This looks good to me except one problem. It probably isn't a problem for this PR, but should be a new issue. When I run base_test.sh
I get the following output in test_all_geoips_base.log_test_interfaces.log
:
/home/jsolbrig/geoips/github/geoips/tests/utils/test_all_run.sh: line 33: test_interfaces: command not found
@mindyls Do you know what is causing this? If needed, can you please create an issue to fix this problem, then merge?
This looks good to me except one problem. It probably isn't a problem for this PR, but should be a new issue. When I run
base_test.sh
I get the following output intest_all_geoips_base.log_test_interfaces.log
:/home/jsolbrig/geoips/github/geoips/tests/utils/test_all_run.sh: line 33: test_interfaces: command not found
@mindyls Do you know what is causing this? If needed, can you please create an issue to fix this problem, then merge?
I fixed this one internal after I pulled in the last github.com updates. I say just approve and we will merge this, and don't even create an issue until after I've pushed 1.13.0 back out (should be fixed there)
Okay, sounds good. Thanks @mindyls!
Reviewer Checklist
python >= 3.10.0
in their pyproject.toml. I'm going to wait to make those PR requests until I can find all references ofpython 3.9
in the main GeoIPS repository.Related Issues
fixes NRLMMD-GEOIPS/geoips#439
Testing Instructions
Run
./tests/integration_tests/full_test.sh
and get an output of 0.Summary
'There are a few places in the code where we explicitly attempt to support Python 3.9 but supporting 3.9 is beginning to hold us back in some ways. We should explicitly remove support for Python 3.9 and update the code to remove all related special cases.'
Since Python 3.9 and older versions are holding GeoIPS back, and since primary GeoIPS users are using Python versions greater than or equal to 3.10.0, we are removing all support for versions less than 3.10. The following files have been modified to implement those changes.