NRLMMD-GEOIPS / geoips

Main Geolocated Information Processing System code base with basic functionality enabled.
https://nrlmmd-geoips.github.io/geoips/
Other
13 stars 10 forks source link

Move test_interfaces out of geoips/commandline and into tests directory #526

Open mindyls opened 2 months ago

mindyls commented 2 months ago

Requested Update

Description

This entire script may be a duplicate of various pytests, so could potentially eventually be removed if we confirm 100% of the things tested in test_interfaces are tested via pytests.

Background and Motivation

Alternative Solutions

Environment

Code to demonstrate issue

Checklist for Completion

evrose54 commented 2 months ago

See issue #496, which discusses where, when, and how we should validate the plugin registries. In PR #442, we moved the Pytest functionality attached to plugin_registry.py to geoips/tests/unit_tests/plugin_registries/test_plugin_registries.py. Therefore, test_interfaces.py shouldn't actually include any Pytest references. Rather, it's still using plg_reg.validate_all_registries and plg_reg.validate_registry, which are the functions that were moved to the unit tests. In my opinion, we should just remove those portions of test_interfaces.py, and reconsider where and when we'd like to validate the plugin registries. test_interfaces.py is failing because of those previous calls I mentioned.

evrose54 commented 2 months ago

See #527.