NRLMMD-GEOIPS / geoips

Main Geolocated Information Processing System code base with basic functionality enabled.
https://nrlmmd-geoips.github.io/geoips/
Other
14 stars 11 forks source link

526 test interfaces refactor #527

Closed evrose54 closed 2 months ago

evrose54 commented 5 months ago

Reviewer Checklist

Related Issues

fixes NRLMMD-GEOIPS/geoips#526 possibly fixes NRLMMD-GEOIPS/geoips#496

Testing Instructions

Run python geoips/commandline/test_interface.py and get a successful output.

Summary

From NRLMMD-GEOIPS/geoips#526: 2024-04-29, Move test_interfaces out of geoips/commandline and into tests directory

This stems from NRLMMD-GEOIPS/geoips#442: 2024-04-16, Move PyTest functionality from PluginRegistry Class to Unit Tests, which moved all pytest-dependent functions of the PluginRegistry class to a separate unit test. We missed a reference to this validation in geoips/commandline/test_interfaces.py which ended up failing due to the moved functions. We now invoke the import_optional_dependencies function in geoips/context_managers.py to implement this validation, and if the user does not have pytest installed, we just don't validate the PluginRegistry and continue to interface testing. We probably should discuss this a bit more, to see if we want to refactor the unit tests to not use pytest for validation, or if it is fine leaving it as-is.

modified: geoips/commandline/test_interfaces.py
evrose54 commented 2 months ago

Changes were included in a different PR. Already merged into main. Closing as this is a duplicate PR.