NRLMMD-GEOIPS / geoips

Main Geolocated Information Processing System code base with basic functionality enabled.
https://nrlmmd-geoips.github.io/geoips/
Other
13 stars 10 forks source link

Small CLI Refactors needed in a future PR #541

Open evrose54 opened 1 month ago

evrose54 commented 1 month ago

Requested Update

Description

This issue was created due to lingering comments on the #444 PR. Since that PR is a dependency of other PRs like #465 and #478 , we are going to wait to make those updates and finish them up in a separate PR once those have been merged. Since none of the comments address actual bugs, this is largely just a refactoring change and is good to wait until we merge the aforementioned PRs.

Checklist for Completion

Add to the following list for all comments that still need addressing.

All bullets in the list above that don't have a referenced issue are either described in their entirety above or will most likely not be addressed / relevant in the future. For example, the point talking about geoips test unit-test doesn't have an issue as that functionality will likely be removed.

evrose54 commented 1 month ago

A larger change (I'll create another issue later) will be implementing logging within the CLI. See Jeremy's comment at https://github.com/NRLMMD-GEOIPS/geoips/pull/444/files#r1592810697