NRLMMD-GEOIPS / geoips

Main Geolocated Information Processing System code base with basic functionality enabled.
https://nrlmmd-geoips.github.io/geoips/
Other
13 stars 10 forks source link

Fix Bug In ``setup/download_test_data.py`` #625

Closed evrose54 closed 2 weeks ago

evrose54 commented 3 weeks ago

Requested Update

Description

When addressing issue #624 I ran into a bug where the test data in check_system_requirements.sh:test_data_urls was actually being dumped into a log file rather than being decompressed in its appropriate location. This stemmed from code updates introduced in #530. The aforementioned PR changed how download_test_data.py was called within check_system_requirements.sh, and instead of piping to a tar extraction command, we directly dump the output of download_test_data.py into a log file instead. This works for GitHub hosted test datasets, but not files that are hosted on nextcloud. We should update the non .git portion of download_test_data.py to extract the data within the python module, and print the output of the tar extraction to the log file instead.

Background and Motivation

This stems from a bug introduced in #530 when trying to work on #624.

Code to demonstrate issue

Checklist for Completion