When addressing issue #624 I ran into a bug where the test data in check_system_requirements.sh:test_data_urls was actually being dumped into a log file rather than being decompressed in its appropriate location. This stemmed from code updates introduced in #530. The aforementioned PR changed how download_test_data.py was called within check_system_requirements.sh, and instead of piping to a tar extraction command, we directly dump the output of download_test_data.py into a log file instead. This works for GitHub hosted test datasets, but not files that are hosted on nextcloud. We should update the non .git portion of download_test_data.py to extract the data within the python module, and print the output of the tar extraction to the log file instead.
Background and Motivation
This stems from a bug introduced in #530 when trying to work on #624.
Code to demonstrate issue
setup/check_system_requirements.sh
setup/download_test_data.py
Checklist for Completion
Use tarfile extraction in download_test_data.py for non .git based test datasets.
Requested Update
Description
When addressing issue #624 I ran into a bug where the test data in
check_system_requirements.sh:test_data_urls
was actually being dumped into a log file rather than being decompressed in its appropriate location. This stemmed from code updates introduced in #530. The aforementioned PR changed howdownload_test_data.py
was called withincheck_system_requirements.sh
, and instead of piping to a tar extraction command, we directly dump the output ofdownload_test_data.py
into a log file instead. This works for GitHub hosted test datasets, but not files that are hosted on nextcloud. We should update the non.git
portion ofdownload_test_data.py
to extract the data within the python module, and print the output of the tar extraction to the log file instead.Background and Motivation
This stems from a bug introduced in #530 when trying to work on #624.
Code to demonstrate issue
setup/check_system_requirements.sh
setup/download_test_data.py
Checklist for Completion
tarfile
extraction indownload_test_data.py
for non.git
based test datasets.