[x] Required existing tests pass (ie full_test.sh, others as appropriate)
[x] Required unit tests pass for new/modified functionality
[x] NO REQUIRED integration tests (explain why not required)
[x] NO REQUIRED documentation (explain why not required)
[x] Required release notes added for new/modified functionality
[x] NO REQUIRED updates to other repos (explain why not required)
Related Issues
No issue; quick fix to make config install unit tests pass faster.
Testing Instructions
Run pytest -v tests/unit_tests/commandline/test_geoips_config_install.py without any test datasets installed. Shouldn't install anything but will test for correct output.
Summary
Previously the config install unit tests actually installed test datasets if they
were missing. This is completely uneccessary and shouldn't be performed in the unit
tests, only if a user actually wants to install data. To fix this, we've added a hidden
argument to config install, called --test-mode, which will skip the download
portion of the code if specified. While not perfect, this ensures that the unit tests
will run fast and output the correct information.
Reviewer Checklist
Related Issues
No issue; quick fix to make config install unit tests pass faster.
Testing Instructions
Run
pytest -v tests/unit_tests/commandline/test_geoips_config_install.pywithout any test datasets installed. Shouldn't install anything but will test for correct output.Summary
Previously the
config installunit tests actually installed test datasets if they were missing. This is completely uneccessary and shouldn't be performed in the unit tests, only if a user actually wants to install data. To fix this, we've added a hidden argument toconfig install, called--test-mode, which will skip the download portion of the code if specified. While not perfect, this ensures that the unit tests will run fast and output the correct information.