Closed biosafetylvl5 closed 3 weeks ago
I just ran base_test.sh to see what that got me to start with. I get one failure from that in a YAML file diff.
27_162923 log_setup.py:50 INTERACTIVE: ********************************************************************************
27_162923 log_setup.py:55 INTERACTIVE: ** BAD Text files do NOT match exactly **
27_162923 log_setup.py:55 INTERACTIVE: ** output_product: **
27_162923 log_setup.py:55 INTERACTIVE: ** /home/jsolbrig/geoips/review/outdirs/preprocessed/tcwww/tc2020/IO/IO012020/metadata/sector_information/20200518/20200518_073601_IO012020_amsr2_gcom-w1_windspeed_140kts_85p45_1p0-clean.png.yaml **
27_162923 log_setup.py:55 INTERACTIVE: ** compare_product: **
27_162923 log_setup.py:55 INTERACTIVE: ** /home/jsolbrig/geoips/review/geoips/tests/outputs/amsr2_ocean.tc.windspeed.imagery_clean/20200518_073601_IO012020_amsr2_gcom-w1_windspeed_140kts_85p45_1p0-clean.png.yaml **
27_162923 log_setup.py:55 INTERACTIVE: ** out_difftxt: **
27_162923 log_setup.py:55 INTERACTIVE: ** /home/jsolbrig/geoips/review/geoips/tests/outputs/amsr2_ocean.tc.windspeed.imagery_clean/diff_test_output_dir_jsolbrig/diff_test_output_20200518_073601_IO012020_amsr2_gcom-w1_windspeed_140kts_85p45_1p0-clean.png.yaml **
27_162923 log_setup.py:56 INTERACTIVE: ********************************************************************************
27_162923 log_setup.py:57 INTERACTIVE:
The difference is this:
25,26c25,26
< source_filename: /home/jsolbrig/geoips/review/geoips/tests/sectors/tc_bdecks/bio012020.dat
< source_sector_file: /home/jsolbrig/geoips/review/geoips/tests/sectors/tc_bdecks/bio012020.dat
---
> source_filename: $GEOIPS_PACKAGES_DIR/geoips/tests/sectors/tc_bdecks/bio012020.dat
> source_sector_file: $GEOIPS_PACKAGES_DIR/geoips/tests/sectors/tc_bdecks/bio012020.dat
Those paths point to the same thing but differ in whether the ENV is expanded. The newly produced file expands the ENV while the file used for comparison does not expand the ENV.
On both main and dev-staging, the PATHS variable in filenames/base_paths.py
is about the same:
(geoips) [gwynu@winter geoips]$ cd geoips/filenames/
(geoips) [gwynu@winter filenames]$ python3 -c "import base_paths as b; print(b.PATHS)"
{'BASE_PATH': '/local/home/gwynu/geoips/geoips/geoips', 'GEOIPS_OUTDIRS': '/home/gwynu/geoips/outdirs', 'GEOIPS_PACKAGES_DIR': '/local/home/gwynu/geoips', 'GEOIPS_BASEDIR': '/local/home/gwynu', 'GEOIPS_DOCS_URL': 'https://nrlmmd-geoips.github.io/geoips/', 'GEOIPS_VERS': '0.0.0', 'GEOIPS_OPERATIONAL_USER': False, 'GEOIPS_COPYRIGHT': 'NRL-Monterey', 'GEOIPS_COPYRIGHT_ABBREVIATED': 'NRLMRY', 'GEOIPS_RCFILE': '', 'DEFAULT_QUEUE': None, 'BOXNAME': 'winter.cira.colostate.edu', 'GEOIPS_TESTDATA_DIR': '/home/gwynu/geoips/test_data', 'GEOIPS_DEPENDENCIES_DIR': '/local/home/gwynu/geoips_dependencies', 'PRESECTORED_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/sectored', 'PREREAD_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/unsectored', 'PREREGISTERED_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/registered', 'PRECALCULATED_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/algorithms', 'CLEAN_IMAGERY_PATH': '/home/gwynu/geoips/outdirs/preprocessed/clean_imagery', 'ANNOTATED_IMAGERY_PATH': '/home/gwynu/geoips/outdirs/preprocessed/annotated_imagery', 'FINAL_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/final', 'PREGENERATED_GEOLOCATION_PATH': '/home/gwynu/geoips/outdirs/preprocessed/geolocation', 'SCRATCH': '/home/gwynu/geoips/outdirs/scratch', 'LOCALSCRATCH': '/home/gwynu/geoips/outdirs/scratch', 'SHAREDSCRATCH': '/home/gwynu/geoips/outdirs/scratch', 'LOGDIR': '/home/gwynu/geoips/outdirs/logs', 'GEOIPSDATA': '/home/gwynu/geoips/outdirs/geoipsdata', 'GEOIPS_ANCILDAT_AUTOGEN': '/home/gwynu/geoips/outdirs/ancildat_autogen', 'GEOIPS_ANCILDAT': '/home/gwynu/geoips/outdirs/ancildat', 'TCWWW': '/home/gwynu/geoips/outdirs/preprocessed/tcwww', 'PUBLICWWW': '/home/gwynu/geoips/outdirs/preprocessed/publicwww', 'PRIVATEWWW': '/home/gwynu/geoips/outdirs/preprocessed/privatewww', 'TC_DECKS_DB': '/home/gwynu/geoips/outdirs/longterm_files/tc/tc_decks.db', 'TC_DECKS_DIR': '/home/gwynu/geoips/outdirs/longterm_files/tc/decks', 'TC_TEMPLATE': '/local/home/gwynu/geoips/geoips/geoips/plugins/yaml/sectors/dynamic/tc_web_template.yaml', 'HOME': '/home/gwynu', 'TCWWW_URL': '/home/gwynu/geoips/outdirs/preprocessed/tcwww', 'PUBLICWWW_URL': '/home/gwynu/geoips/outdirs/preprocessed/publicwww', 'PRIVATEWWW_URL': '/home/gwynu/geoips/outdirs/preprocessed/privatewww'}
(geoips) [gwynu@winter filenames]$ git switch main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
(geoips) [gwynu@winter filenames]$ python3 -c "import base_paths as b; print(b.PATHS)"
{'BASE_PATH': '/local/home/gwynu/geoips/geoips/geoips/filenames/..', 'GEOIPS_DOCS_URL': 'https://nrlmmd-geoips.github.io/geoips/', 'GEOIPS_OPERATIONAL_USER': False, 'GEOIPS_OUTDIRS': '/home/gwynu/geoips/outdirs', 'GEOIPS_PACKAGES_DIR': '/home/gwynu/geoips', 'GEOIPS_BASEDIR': '/home/gwynu/geoips/..', 'GEOIPS_TESTDATA_DIR': '/home/gwynu/geoips/test_data', 'GEOIPS_DEPENDENCIES_DIR': '/home/gwynu/geoips/../geoips_dependencies', 'PRESECTORED_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/sectored', 'PREREAD_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/unsectored', 'PREREGISTERED_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/registered', 'PRECALCULATED_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/algorithms', 'CLEAN_IMAGERY_PATH': '/home/gwynu/geoips/outdirs/preprocessed/clean_imagery', 'ANNOTATED_IMAGERY_PATH': '/home/gwynu/geoips/outdirs/preprocessed/annotated_imagery', 'FINAL_DATA_PATH': '/home/gwynu/geoips/outdirs/preprocessed/final', 'PREGENERATED_GEOLOCATION_PATH': '/home/gwynu/geoips/outdirs/preprocessed/geolocation', 'GEOIPS_COPYRIGHT': 'NRL-Monterey', 'GEOIPS_COPYRIGHT_ABBREVIATED': 'NRLMRY', 'GEOIPS_RCFILE': '', 'TC_TEMPLATE': '/local/home/gwynu/geoips/geoips/geoips/filenames/../plugins/yaml/sectors/dynamic/tc_web_template.yaml', 'DEFAULT_QUEUE': None, 'BOXNAME': 'winter.cira.colostate.edu', 'HOME': '/home/gwynu', 'SCRATCH': '/home/gwynu/geoips/outdirs/scratch', 'LOCALSCRATCH': '/home/gwynu/geoips/outdirs/scratch', 'SHAREDSCRATCH': '/home/gwynu/geoips/outdirs/scratch', 'GEOIPS_ANCILDAT': '/home/gwynu/geoips/outdirs/ancildat', 'GEOIPS_ANCILDAT_AUTOGEN': '/home/gwynu/geoips/outdirs/ancildat_autogen', 'LOGDIR': '/home/gwynu/geoips/outdirs/logs', 'GEOIPSDATA': '/home/gwynu/geoips/outdirs/geoipsdata', 'GEOIPS_VERS': '0.0.0', 'TCWWW': '/home/gwynu/geoips/outdirs/preprocessed/tcwww', 'TCWWW_URL': '/home/gwynu/geoips/outdirs/preprocessed/tcwww', 'PUBLICWWW': '/home/gwynu/geoips/outdirs/preprocessed/publicwww', 'PUBLICWWW_URL': '/home/gwynu/geoips/outdirs/preprocessed/publicwww', 'PRIVATEWWW': '/home/gwynu/geoips/outdirs/preprocessed/privatewww', 'PRIVATEWWW_URL': '/home/gwynu/geoips/outdirs/preprocessed/privatewww', 'TC_DECKS_DB': '/home/gwynu/geoips/outdirs/longterm_files/tc/tc_decks.db', 'TC_DECKS_DIR': '/home/gwynu/geoips/outdirs/longterm_files/tc/decks'}
(geoips) [gwynu@winter filenames]$
and both are certainly initialized. Nor is there another method in base_paths that was edited...
The failure in base_test
comes from amsr2_ocean.tc.windspeed.imagery_clean.sh
(for me: /home/gwynu/geoips/geoips/tests/scripts/amsr2_ocean.tc.windspeed.imagery_clean.sh
)
On main, both the compare and the generated file have unexpanded env variables.
Replacing the base_paths.py file with the file from main
resolves the issue.
Fixed in PR
Description
Code to demonstrate issue
Dockerfile
Install Log
Run Log